Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

support building with libgmp as well as num-bigint #152

Draft
wants to merge 9 commits into
base: main
Choose a base branch
from
Draft

support building with libgmp as well as num-bigint #152

wants to merge 9 commits into from

Conversation

arvidn
Copy link
Contributor

@arvidn arvidn commented Nov 12, 2021

the mpz_import and mpz_export functions are quite a bit slower than the num-bigint counterparts, so this slows down the benchmarks somewhat.

The rationale for this is:

  1. use more main-stream code, with lower security risks
  2. (possibly) use the same instance of libgmp as we already use in chiavdf and bls-signatures

@arvidn

This comment has been minimized.

Sign in to view
@arvidn arvidn force-pushed the libgmp-transition branch 3 times, most recently from 2ae18b8 to e2bb2b2 Compare November 19, 2021 18:11
@arvidn arvidn force-pushed the libgmp-transition branch from 755af93 to 9f7c043 Compare January 12, 2022 13:48
@arvidn arvidn changed the title use libgmp for bignum instead of num-bigint support building with libgmp as well as num-bigint Jan 13, 2022
@arvidn arvidn force-pushed the libgmp-transition branch from 9df97b1 to 4d13ac0 Compare January 13, 2022 13:10
@github-actions
Copy link

'This PR has been flagged as stale due to no activity for over 60
days. It will not be automatically closed, but it has been given
a stale-pr label and should be manually reviewed.'

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
stale-pr
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@arvidn