2686 delete forward from comment

[pbwolf]

What has changed?

whenContexts.setCursorContextIfChanged is called not upon only changeTextEditorSelection and changeActiveTextEditor (as before), but also changeTextDocument - to account for the case where a document change affected the meaning of the active point without moving it.

Since most edits also move the active point, a check is added to avoid redundant calls to setCursorContextIfChanged. The check compares the event's editor, document version, and active point with those of the previous event.

Tests: I have not figured out how to automate keypresses. The test would start with the document |;•(foo) where | signifies the active point and • is a newline; press Del (removing the semicolon), Del again (removing the newline), and Del again (passing harmlessly over the open-paren? or erroneously deleting it?).

Alternative: There is also a changeTextDocument handler in mirror-doc. It might be a more robust place to adjust cursor context, although it would complicate coordination of edit- vs selection-occasioned adjustment. The thing is that the mirror-doc handler updates the model, which is used in whenContexts.setCursorContextIfChanged. Luckily, the problematic case involves TWO presses of Del and therefore in practice the present, un-tangled, change will address it.

Fixes #2686

My Calva PR Checklist

I have:

• Read How to Contribute.
• Directed this pull request at the dev branch. (Or have specific reasons to target some other branch.)
• Made sure I have changed the PR base branch, so that it is not published. (Sorry for the nagging.)
• Made sure there is an issue registered with a clear problem statement that this PR addresses, (created the issue if it was not present).
  • Updated the [Unreleased] entry in CHANGELOG.md, linking the issue(s) that the PR is addressing.
• Figured if anything about the fix warrants tests on Mac/Linux/Windows/Remote/Whatever, and either tested it there if so, or mentioned it in the PR.
• (No docs changes) Added to or updated docs in this branch, if appropriate
• Tests (see above)
  • Tested the particular change
  • Figured if the change might have some side effects and tested those as well.
• Formatted all JavaScript and TypeScript code that was changed. (use the prettier extension or run npm run prettier-format)
• Confirmed that there are no linter warnings or errors (use the eslint extension, run npm run eslint before creating your PR, or run npm run eslint-watch to eslint as you go).

Ping @PEZ, @bpringe, @corasaurus-hex, @Cyrik

[netlify]

✅ Deploy Preview for calva-docs ready!

Name	Link
🔨 Latest commit	aa0713f
🔍 Latest deploy log	https://app.netlify.com/sites/calva-docs/deploys/677583b1dd9f3b00089af059
😎 Deploy Preview	https://deploy-preview-2690--calva-docs.netlify.app
📱 Preview on mobile	Toggle QR Code... Use your smartphone camera to open QR code link.

---

To edit notification comments on pull requests, go to your Netlify site configuration.

[bpringe]

Thanks for this contribution and for your other work on Calva! Is this still a WIP as the title suggests?

[pbwolf]

@bpringe it is ready for your review. Thank you.