Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Calling][Bug] Update the bottom sheet accessibility #1084

Open
wants to merge 7 commits into
base: develop
Choose a base branch
from

Conversation

ShaunaSong
Copy link
Member

Purpose

  • Remove the title order for accessibility

Does this introduce a breaking change?

  • Yes
  • No

Pull Request Type

What kind of change does this Pull Request introduce?

  • Bugfix
  • Feature
  • Code style update (formatting, local variables)
  • Refactoring (no functional changes, no api changes)
  • Documentation content changes
  • Other... Please describe:

Pull Request Checklist

  • Public API changes
  • Verified for cross-platform
  • Synced with iOS, Web team
  • Internal review completed
  • UI Changes
    • Screen captures included
    • Tested for Light/Dark mode
    • Tested for screen rotation
    • Tested on Tablet and small screen device (5")
    • Include localization changes
  • Tests
    • Memory leak analysis performed
    • Tested on API 21, 26 and latest
    • Tested for background mode
    • Unit Tests Included
    • UI Automated Tests Included

How to Test

  • Open...
  • Click on...

What to Check

Verify that the following are valid

  • ...

Other Information

iaulakh
iaulakh previously approved these changes Sep 13, 2024
Mohtasim
Mohtasim previously approved these changes Sep 13, 2024
@ShaunaSong ShaunaSong dismissed stale reviews from Mohtasim and iaulakh via f7e21b6 September 13, 2024 17:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants