Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update README.md - added note for MOE LLM deployments compatibility with ai inference sdk #39038

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

jakeatmsft
Copy link

@jakeatmsft jakeatmsft commented Jan 6, 2025

added note for MOE LLM deployments.

Description

Please add an informative description that covers that changes made by the pull request and link all relevant issues.

If an SDK is being regenerated based on a new swagger spec, a link to the pull request containing these swagger spec changes has been included above.

All SDK Contribution checklist:

  • The pull request does not introduce [breaking changes]
  • CHANGELOG is updated for new features, bug fixes or other significant changes.
  • I have read the contribution guidelines.

General Guidelines and Best Practices

  • Title of the pull request is clear and informative.
  • There are a small number of commits, each of which have an informative message. This means that previously merged commits do not appear in the history of the PR. For more information on cleaning up the commits in your PR, see this page.

Testing Guidelines

  • Pull request includes test coverage for the included changes.

added note for MOE LLM deployments.
@jakeatmsft jakeatmsft requested a review from dargilco as a code owner January 6, 2025 17:36
Copy link

github-actions bot commented Jan 6, 2025

Thank you for your contribution @jakeatmsft! We will review the pull request and get back to you soon.

@github-actions github-actions bot added AI Model Inference Issues related to the client library for Azure AI Model Inference (\sdk\ai\azure-ai-inference) Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization. labels Jan 6, 2025
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@@ -42,6 +42,7 @@ See [Prerequisites](https://github.com/Azure/azure-sdk-for-python/blob/main/sdk/
To construct any of the clients, you will need to pass in the endpoint URL. If you are using key authentication, you also need to pass in the key associated with your deployed AI model.

* For Serverless API and Managed Compute endpoints, the endpoint URL has the form `https://your-unique-resouce-name.your-azure-region.models.ai.azure.com`, where `your-unique-resource-name` is your globally unique Azure resource name and `your-azure-region` is the Azure region where the model is deployed (e.g. `eastus2`).
* For Managed Online Endpoints, do not include the inference path (e.g. `/score`) in endpoint URL.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I checked, the official term in the documentation is "Managed Compue", not "Managed Online". Can you please update your new line to say "Managed Compute"? Thanks!

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Last time I checked, the official term in the documentation is "Managed Compue", not "Managed Online". Can you please update your new line to say "Managed Compute"? Thanks!

fixed!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
AI Model Inference Issues related to the client library for Azure AI Model Inference (\sdk\ai\azure-ai-inference) Community Contribution Community members are working on the issue customer-reported Issues that are reported by GitHub users external to the Azure organization.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants