Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[SB] pyAMQP retries #39037

Draft
wants to merge 3 commits into
base: main
Choose a base branch
from
Draft

[SB] pyAMQP retries #39037

wants to merge 3 commits into from
+4 −2

Conversation

l0lawrence
Copy link
Member

@l0lawrence l0lawrence commented Jan 6, 2025 •
edited
Loading

set retries to 0 to reduce time lag between pyAMQP and uAMQP retries, sdk should still retry 3 times

  • tests passing
  • stress tests
  • check with other languages
  • Go: a detach gets to the sdk level, which after investigating the error then chooses to retry (reattach link) or not
  • .NET: a detach is treated in an on-demand context, if the detach happens outside of an operation call it will be retried at the amqp stack level on demand, elsewise it will be handled by the sdk for reattaching/retrying in the context of the operation
  • [ ]

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

@l0lawrence
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@l0lawrence
Copy link
Member Author

/azp run python - servicebus - tests

@azure-pipelines Azure Pipelines
Copy link

Azure Pipelines successfully started running 1 pipeline(s).

@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

1 similar comment
@azure-sdk
Copy link
Collaborator

API change check

API changes are not detected in this pull request.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@annatisch annatisch Awaiting requested review from annatisch annatisch will be requested when the pull request is marked ready for review annatisch is a code owner

@kashifkhan kashifkhan Awaiting requested review from kashifkhan kashifkhan will be requested when the pull request is marked ready for review kashifkhan is a code owner

@swathipil swathipil Awaiting requested review from swathipil swathipil will be requested when the pull request is marked ready for review swathipil is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
Service Bus
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@l0lawrence @azure-sdk