Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix flaky reqs parse tool test #39027

Merged
merged 1 commit into from
Jan 7, 2025
Merged

fix flaky reqs parse tool test #39027

merged 1 commit into from
Jan 7, 2025

Conversation

kristapratico
Copy link
Member

@kristapratico kristapratico commented Jan 3, 2025

Any time one of these hardcoded packages/versions gets released, the test_replace_dev_reqs_relative test starts failing. Updating test to lookup the expected version.

Example failure: https://github.com/Azure/azure-sdk-for-python/actions/runs/12604508975/job/35131569305?pr=38963

Copy link
Member

@mccoyp mccoyp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a great idea to me!

@kristapratico kristapratico merged commit ba4a6fc into main Jan 7, 2025
41 checks passed
@kristapratico kristapratico deleted the fix-tool-test branch January 7, 2025 17:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants