Stream with event queue #38996
Open
Stream with event queue #38996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhakulin
requested review from
luigiw,
needuv,
achauhan-scc,
kingernupur,
paulshealy1,
singankit,
dargilco and
jayesh-tanna
as code owners
|
API change check API changes are not detected in this pull request. |
dargilco
approved these changes
Dec 27, 2024
howieleung
reviewed
Dec 27, 2024
| if self.buffer: | ||
| event = await self._process_event(self.buffer) | ||
| self.buffer = "" # we've parsed it | ||
| if event: |
There was a problem hiding this comment.
I think you can modify _process_event to return without Optional and eliminate the if event check here.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added the _event_queue in stream handling because anext is designed to produce only one event (or item) per iteration. If the response stream delivers multiple events within a single chunk of data, we would need to queue up all those events and then return them one-at-a-time in subsequent calls to anext. Otherwise, if we return the first parsed event and discard the rest in that same call leads to lost events.