fix: handle URL-safe base64 decoding for JWT #38991
Open
+5
−2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Updated the JWT decoding logic to use URL-safe base64 decoding. - Added padding to the base64 encoded string to ensure proper decoding. - This fixes the issue where UTF-8 decoding errors occurred due to missing padding in the base64 string. Changes: - Replaced `base64.decodebytes` with `base64.urlsafe_b64decode`. - Added logic to calculate and append necessary padding to the base64 string.
baku2san
requested review from
pvaneck,
xiangyan99 and
a team
as code owners
baku2san
requested review from
billwert,
g2vinay,
ahsonkhan,
chlowell and
mpodwysocki
github-actions
bot
added
Azure.Identity
Community Contribution
|
Thank you for your contribution @baku2san! We will review the pull request and get back to you soon. |
|
API change check API changes are not detected in this pull request. |
pvaneck
reviewed
Jan 6, 2025
There was a problem hiding this comment.
Thanks for the PR and improving the JWT payload decoding! Left a suggestion inline.
Do you mind also adding this change to the async decorator as well?
| base64_meta_data = token.token.split(".")[1].encode("utf-8") + b"==" | ||
| json_bytes = base64.decodebytes(base64_meta_data) | ||
| base64_meta_data = token.token.split(".")[1] | ||
| padding_needed = 4 - (len(base64_meta_data) % 4) |
There was a problem hiding this comment.
A more concise way to achieve the same result while avoiding the potential for the padding_needed value to be 4.
Suggested change
| padding_needed = 4 - (len(base64_meta_data) % 4) | |
| padding_needed = -len(base64_meta_data) % 4 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This pull request addresses an issue with JWT decoding where URL-safe base64 decoding was not being used, leading to UTF-8 decoding errors. The changes ensure that the base64 encoded string is properly padded and decoded using URL-safe base64 decoding.
RFC4648
Changes:
base64.decodebyteswithbase64.urlsafe_b64decode.All SDK Contribution checklist:
General Guidelines and Best Practices
Testing Guidelines