[azkeys] convert to typespec #23776
[azkeys] convert to typespec #23776
Conversation
gracewilcox
added
KeyVault
Client
gracewilcox
force-pushed
the
tsp-azkeys
branch
from
2bfcab8 to
d7edc15
Compare
gracewilcox
requested review from
ArcturusZhang,
lirenhe,
tadelesh,
richardpark-msft,
jhendrixMSFT,
RickWinter and
chlowell
as code owners
gracewilcox
force-pushed
the
tsp-azkeys
branch
from
5e16d76 to
02e8542
Compare
gracewilcox
removed request for
tadelesh,
RickWinter,
lirenhe,
ArcturusZhang and
richardpark-msft
| regexReplace("constants.go", `.*(\bKeyOperationExport\b).*`, "") | ||
|
|
||
| // delete strconv | ||
| regexReplace("client.go", `\"strconv\"`, "") |
There was a problem hiding this comment.
If you use goimports, instead of gofmt, then it'll trim out unused imports for you.
There was a problem hiding this comment.
Hmm we must have a bug in the emitter. We shouldn't be adding unnecessary imports.
There was a problem hiding this comment.
I have had this happen, on occasion, when I remove code (in a transform) that used to call a helper function. Not sure when strconv is used in our generated code.
There was a problem hiding this comment.
Good point and that's what's happening here. strconv is used for setting the maxresults header and that's being stripped out via a transform.
There was a problem hiding this comment.
If running goimports instead of gofmt obviates this replacement, we should do that instead
gracewilcox
force-pushed
the
tsp-azkeys
branch
from
02e8542 to
d09d2b5
Compare
gracewilcox
force-pushed
the
tsp-azkeys
branch
from
d09d2b5 to
02b425c
Compare
| } | ||
|
|
||
| func main() { | ||
| // delete the version path param check (version == "" is legal for Key Vault but indescribable by OpenAPI) |
There was a problem hiding this comment.
we've left OpenAPI behind, need something like
| // delete the version path param check (version == "" is legal for Key Vault but indescribable by OpenAPI) | |
| // delete the version path param check (TypeSpec doesn't allow optional path parameters) |
| @@ -28,7 +24,7 @@ type DecryptResponse struct { | |||
|
|
|||
| // DeleteKeyResponse contains the response from method Client.DeleteKey. | |||
| type DeleteKeyResponse struct { | |||
| // A DeletedKey consisting of a WebKey plus its Attributes and deletion info | |||
| // A DeletedKey consisting of a WebKey plus its Attributes and deletion info | |||
There was a problem hiding this comment.
Is this extra space in the source?
| @@ -18,15 +14,17 @@ type BackupKeyResult struct { | |||
|
|
|||
| // CreateKeyParameters - The key create parameters. | |||
| type CreateKeyParameters struct { | |||
| // REQUIRED; The type of key to create. | |||
| // REQUIRED; The type of key to create. For valid values, see JsonWebKeyType. | |||
There was a problem hiding this comment.
But we renamed JsonWebKeyType to KeyType. Is this blurb added by the emitter?
Converting keys to generate with typespec
part of #23458