New cmdlets for Microsoft peering prefix validation #26969
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
️✔️Az.Accounts
️✔️Az.ApplicationInsights
️✔️Az.Batch
️✔️Az.CognitiveServices
️✔️Az.Compute
️✔️Az.ContainerRegistry
️✔️Az.CosmosDB
️✔️Az.DataLakeStore
️✔️Az.Dns
️✔️Az.EventHub
|
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09 % | Test coverage for the module cannot be lower than 50%. |
⚠️ - MacOS
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
⚠️ PowerShell Core - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
⚠️ Windows PowerShell - Windows
| Type | Title | Current Coverage | Description |
|---|---|---|---|
| Test Coverage Less Than 50% | 22.09% | Test coverage for the module cannot be lower than 50%. |
️✔️Az.Maintenance
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 17.39 % Test coverage for the module cannot be lower than 50%.
⚠️ - MacOS
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 17.39% Test coverage for the module cannot be lower than 50%.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 17.39% Test coverage for the module cannot be lower than 50%.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Description ⚠️ Test Coverage Less Than 50% 17.39% Test coverage for the module cannot be lower than 50%.
⚠️ Az.NetAppFiles
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 75.00 % 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 75.00% 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 75.00% 78.87% Test coverage cannot be lower than the number of the last release.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 75.00% 78.87% Test coverage cannot be lower than the number of the last release.
❌Az.Network
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Breaking Change Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Signature Check
❌PowerShell Core - Windows
Type Cmdlet Description Remediation ❌ Add-AzExpressRouteCircuitMicrosoftPeeringPrefixConfig Add-AzExpressRouteCircuitMicrosoftPeeringPrefixConfig Does not support ShouldProcess but the cmdlet verb Add indicates that it should. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue ❌ Remove-AzExpressRouteCircuitMicrosoftPeeringPrefixConfig Remove-AzExpressRouteCircuitMicrosoftPeeringPrefixConfig Does not support ShouldProcess but the cmdlet verb Remove indicates that it should. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue ❌ Set-AzExpressRouteCircuitMicrosoftPeeringPrefixConfig Set-AzExpressRouteCircuitMicrosoftPeeringPrefixConfig Does not support ShouldProcess but the cmdlet verb Set indicates that it should. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue ❌Windows PowerShell - Windows
Type Cmdlet Description Remediation ❌ Add-AzExpressRouteCircuitMicrosoftPeeringPrefixConfig Add-AzExpressRouteCircuitMicrosoftPeeringPrefixConfig Does not support ShouldProcess but the cmdlet verb Add indicates that it should. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue ❌ Remove-AzExpressRouteCircuitMicrosoftPeeringPrefixConfig Remove-AzExpressRouteCircuitMicrosoftPeeringPrefixConfig Does not support ShouldProcess but the cmdlet verb Remove indicates that it should. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue ❌ Set-AzExpressRouteCircuitMicrosoftPeeringPrefixConfig Set-AzExpressRouteCircuitMicrosoftPeeringPrefixConfig Does not support ShouldProcess but the cmdlet verb Set indicates that it should. Determine if the cmdlet should implement ShouldProcess and if so determine if it should implement Force / ShouldContinue ️✔️Help File Existence Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ File Change Check
⚠️ PowerShell Core - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Network. Add a changelog record under Upcoming Release section with past tense.
⚠️ Windows PowerShell - Windows
Type Cmdlet Description Remediation ⚠️ It is required to update ChangeLog.md if you want to release a new version for Az.Network. Add a changelog record under Upcoming Release section with past tense. ️✔️UX Metadata Check
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
❌Generated Sdk Check
❌PowerShell Core - Windows
Type Module Sdk Description Remediation ❌ Az.Network src/Network/Network.Management.Sdk Generated code for Az.Network is not up to date or you have updated generated Sdk. You may need to rebase on the latest main, regenerate code accroding to README.md file under src/Network/Network.Management.Sdk, and make sure no more updates based on generated files. ❌Windows PowerShell - Windows
Type Module Sdk Description Remediation ❌ Az.Network src/Network/Network.Management.Sdk Generated code for Az.Network is not up to date or you have updated generated Sdk. You may need to rebase on the latest main, regenerate code accroding to README.md file under src/Network/Network.Management.Sdk, and make sure no more updates based on generated files. ️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ServiceBus
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.SignalR
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
⚠️ Test
⚠️ - Linux
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 62.15 % 62.22% Test coverage cannot be lower than the number of the last release.
⚠️ - MacOS
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 62.15% 62.22% Test coverage cannot be lower than the number of the last release.
⚠️ PowerShell Core - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 62.15% 62.22% Test coverage cannot be lower than the number of the last release.
⚠️ Windows PowerShell - Windows
Type Title Current Coverage Last Coverage Description ⚠️ Test Coverage Less Than 80% 62.15% 62.22% Test coverage cannot be lower than the number of the last release.
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Test
️✔️ - Linux
️✔️ - MacOS
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
|
PowerShell cmdlets was signed off in the review: https://github.com/Azure/azure-powershell-cmdlet-review-pr/issues/1466 |
|
/azp run |
|
Azure Pipelines successfully started running 3 pipeline(s). |
YanaXu
reviewed
Jan 7, 2025
| // Code generated by Microsoft (R) AutoRest Code Generator. | ||
| // Changes may cause incorrect behavior and will be lost if the code is regenerated. | ||
|
|
||
| namespace Microsoft.Azure.Management.Network.Models |
There was a problem hiding this comment.
Do you update the README.md and generate the code by "autorest --use:@autorest/[email protected]"? Please submit the update of README.md.
| @@ -99,7 +99,8 @@ CmdletsToExport = 'Add-AzApplicationGatewayAuthenticationCertificate', | |||
| 'Add-AzApplicationGatewayUrlPathMapConfig', 'Add-AzDelegation', | |||
| 'Add-AzExpressRouteCircuitAuthorization', | |||
| 'Add-AzExpressRouteCircuitConnectionConfig', | |||
| 'Add-AzExpressRouteCircuitPeeringConfig', | |||
|
|
||
| namespace Microsoft.Azure.Commands.Network | ||
| { | ||
| [Cmdlet("Add", ResourceManager.Common.AzureRMConstants.AzureRMPrefix + "ExpressRouteCircuitMicrosoftPeeringPrefixConfig", DefaultParameterSetName = "SetByResource"), OutputType(typeof(PSExpressRouteCircuit))] |
There was a problem hiding this comment.
Please generate help md files and add tests.
|
This PR was labeled "needs-revision" because it has unresolved review comments or CI failures. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Mandatory Checklist
Please choose the target release of Azure PowerShell. (⚠️ Target release is a different concept from API readiness. Please click below links for details.)
Check this box to confirm: I have read the Submitting Changes section of
CONTRIBUTING.mdand reviewed the following information:ChangeLog.mdfile(s) appropriatelysrc/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.## Upcoming Releaseheader in the past tense.ChangeLog.mdif no new release is required, such as fixing test case only.