Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Powershell support for Subnet peering feature #26906

Open
wants to merge 16 commits into
base: main
Choose a base branch
from

Conversation

udivya73
Copy link

@udivya73 udivya73 commented Dec 19, 2024

Description

Mandatory Checklist

  • SHOULD update ChangeLog.md file(s) appropriately
    • For SDK-based development mode, update src/{{SERVICE}}/{{SERVICE}}/ChangeLog.md.
      • A snippet outlining the change(s) made in the PR should be written under the ## Upcoming Release header in the past tense.
    • For autorest-based development mode, include the changelog in the PR description.
    • Should not change ChangeLog.md if no new release is required, such as fixing test case only.
  • SHOULD regenerate markdown help files if there is cmdlet API change. Instruction
  • SHOULD have proper test coverage for changes in pull request.
  • SHOULD NOT adjust version of module manually in pull request

Copy link

azure-client-tools-bot-prd bot commented Dec 19, 2024

️✔️Az.Accounts
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
️✔️Az.ApplicationInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.Batch
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.CognitiveServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Compute
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.ContainerRegistry
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.CosmosDB
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.DataLakeStore
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Dns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.EventHub
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.KeyVault
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Maintenance
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.ManagedServiceIdentity
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.Monitor
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.NetAppFiles
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
❌Az.Network
❌Build
❌PowerShell Core - Windows
Type Code Position Detail
CS1061 D:\a_work\1\s\src\Network\Network\VirtualNetwork\Peering\AddAzureVirtualNetworkPeeringCommand.cs(127,25) 'PSVirtualNetworkPeering' does not contain a definition for 'LocalSubnetNames' and no accessible extension method 'LocalSubnetNames' accepting a first argument of type 'PSVirtualNetworkPeering' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Network\Network\Network.csproj]
CS1061 D:\a_work\1\s\src\Network\Network\VirtualNetwork\Peering\AddAzureVirtualNetworkPeeringCommand.cs(128,25) 'PSVirtualNetworkPeering' does not contain a definition for 'RemoteSubnetNames' and no accessible extension method 'RemoteSubnetNames' accepting a first argument of type 'PSVirtualNetworkPeering' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Network\Network\Network.csproj]
CS0103 D:\a_work\1\s\src\Network\Network\Models\PSVirtualNetworkPeering.cs(84,54) The name 'LocalSubnetNames' does not exist in the current context [D:\a_work\1\s\src\Network\Network\Network.csproj]
CS0103 D:\a_work\1\s\src\Network\Network\Models\PSVirtualNetworkPeering.cs(90,54) The name 'RemoteSubnetNames' does not exist in the current context [D:\a_work\1\s\src\Network\Network\Network.csproj]
❌Windows PowerShell - Windows
Type Code Position Detail
CS1061 D:\a_work\1\s\src\Network\Network\VirtualNetwork\Peering\AddAzureVirtualNetworkPeeringCommand.cs(127,25) 'PSVirtualNetworkPeering' does not contain a definition for 'LocalSubnetNames' and no accessible extension method 'LocalSubnetNames' accepting a first argument of type 'PSVirtualNetworkPeering' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Network\Network\Network.csproj]
CS1061 D:\a_work\1\s\src\Network\Network\VirtualNetwork\Peering\AddAzureVirtualNetworkPeeringCommand.cs(128,25) 'PSVirtualNetworkPeering' does not contain a definition for 'RemoteSubnetNames' and no accessible extension method 'RemoteSubnetNames' accepting a first argument of type 'PSVirtualNetworkPeering' could be found (are you missing a using directive or an assembly reference?) [D:\a_work\1\s\src\Network\Network\Network.csproj]
CS0103 D:\a_work\1\s\src\Network\Network\Models\PSVirtualNetworkPeering.cs(84,54) The name 'LocalSubnetNames' does not exist in the current context [D:\a_work\1\s\src\Network\Network\Network.csproj]
CS0103 D:\a_work\1\s\src\Network\Network\Models\PSVirtualNetworkPeering.cs(90,54) The name 'RemoteSubnetNames' does not exist in the current context [D:\a_work\1\s\src\Network\Network\Network.csproj]
🔄Breaking Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Signature Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help Example Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Help File Existence Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄File Change Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄UX Metadata Check
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.OperationalInsights
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.PrivateDns
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.RecoveryServices
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.Resources
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.Security
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.ServiceBus
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.SignalR
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
🔄Az.Sql
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows
️✔️Az.Storage
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Az.Websites
️✔️Build
️✔️PowerShell Core - Windows
️✔️Windows PowerShell - Windows
🔄Test
🔄PowerShell Core - Windows
🔄Windows PowerShell - Windows

@VeryEarly VeryEarly self-assigned this Dec 20, 2024
@VeryEarly
Copy link
Contributor

Please help me understand why this is public preview:
image

@udivya73
Copy link
Author

udivya73 commented Dec 24, 2024

Corrected it now, it is targeted for general release @VeryEarly

@udivya73 udivya73 closed this Dec 24, 2024
@udivya73
Copy link
Author

@microsoft-github-policy-service agree company="Microsoft"

@udivya73 udivya73 reopened this Dec 24, 2024
@VeryEarly
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@VeryEarly
Copy link
Contributor

/azp run

Copy link
Contributor

Azure Pipelines successfully started running 3 pipeline(s).

@YanaXu
Copy link
Contributor

YanaXu commented Jan 8, 2025

Hi @udivya73, please fix the build errors.

@YanaXu YanaXu assigned YanaXu and unassigned VeryEarly Jan 8, 2025
Copy link

github-actions bot commented Jan 8, 2025

This PR was labeled "needs-revision" because it has unresolved review comments or CI failures.
Please resolve all open review comments and make sure all CI checks are green. Refer to our guide to troubleshoot common CI failures.

@YanaXu YanaXu added the Network label Jan 8, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants