node22 behind hidden key #7932
Open
node22 behind hidden key #7932
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
shimedh
reviewed
Jan 8, 2025
| @@ -2,6 +2,9 @@ import { WebAppStack } from '../../models/WebAppStackModel'; | |||
| import { getDateString } from '../date-utilities'; | |||
|
|
|||
| const getNodeStack: (useIsoDateFormat: boolean) => WebAppStack = (useIsoDateFormat: boolean) => { | |||
| const node22EOL = getDateString(new Date('2026/04/30'), useIsoDateFormat); | |||
| const node20EOL = getDateString(new Date('2026/04/30'), useIsoDateFormat); | |||
| const node18EOL = getDateString(new Date('2025/04/30'), useIsoDateFormat); | |||
There was a problem hiding this comment.
Are these needed and correct? Asking as the PR title only states that you are adding node22 behind hidekey
|
@Saipriya-1144 Can you abandon this PR, resolve the comment and send it to the ADO repo below as mentioned in the recent communication: |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added node22 behind hidden key to Linux Runtimes for webapps