Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: [NPM] log any error and make sure node ID is set before first log #3145

Closed
huntergregory opened this issue Nov 13, 2024 · 4 comments · Fixed by #3316
Closed

log: [NPM] log any error and make sure node ID is set before first log #3145

huntergregory opened this issue Nov 13, 2024 · 4 comments · Fixed by #3316
Labels
enhancement npm Related to NPM.

Comments

@huntergregory
Copy link
Contributor

huntergregory commented Nov 13, 2024 •
edited
Loading

metrics.SendErrorLog() the error string when running NPM fails

Also, NPM node ID isn't set yet when the first metrics.SendLog() is send (message with: "starting NPM")
@huntergregory huntergregory added enhancement npm Related to NPM. labels Nov 13, 2024
@github-actions GitHub Actions
Copy link

This issue is stale because it has been open for 2 weeks with no activity. Remove stale label or comment or this will be closed in 7 days

@github-actions github-actions bot added the stale Stale due to inactivity. label Nov 28, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented Dec 5, 2024

Issue closed due to inactivity.

@github-actions github-actions bot closed this as not planned Won't fix, can't repro, duplicate, stale Dec 5, 2024
@huntergregory huntergregory reopened this Jan 3, 2025
@huntergregory huntergregory mentioned this issue Jan 3, 2025
Closed
@github-actions github-actions bot removed the stale Stale due to inactivity. label Jan 4, 2025
@huntergregory
Copy link
Contributor Author

node ID can be unset at first because it is populated in the background here:

azure-container-networking/aitelemetry/telemetrywrapper.go

Line 195 in bbe5cb9

go getMetadata(th)

Based on NPM's ai config:

azure-container-networking/npm/metrics/ai-utils.go

Line 24 in bbe5cb9

aiConfig := aitelemetry.AIConfig{

@huntergregory
Copy link
Contributor Author

huntergregory commented Jan 6, 2025 •
edited
Loading

metrics.SendErrorLog() the error string when running NPM fails

We seem to always call this function before exiting with error, except metrics.SendErrorLog() doesn't work as intended in a few places during bootup since telemetry is not initialized until later. See #3316 for more details

@huntergregory huntergregory mentioned this issue Jan 6, 2025
Merged
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
enhancement npm Related to NPM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

log: [NPM] init telemetry before dataplane Azure/azure-container-networking
1 participant
@huntergregory