Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

log: [NPM] on crash, logs not sent to application insights #3299

Open
huntergregory opened this issue Jan 3, 2025 · 1 comment · May be fixed by #3333
Open

log: [NPM] on crash, logs not sent to application insights #3299

huntergregory opened this issue Jan 3, 2025 · 1 comment · May be fixed by #3333
Labels
npm Related to NPM.

Comments

@huntergregory
Copy link
Contributor

huntergregory commented Jan 3, 2025 •
edited
Loading

If NPM crashes, it queues error logs before the crash, but these do not reach app insights since NPM does not clean up the telemetry handle.
@huntergregory huntergregory added the npm Related to NPM. label Jan 3, 2025
@huntergregory huntergregory reopened this Jan 8, 2025
@huntergregory huntergregory changed the title log: [NPM] do we need to wait for Telemetry to send before crashing? log: on crash, logs might not be sent to application insights Jan 8, 2025
@huntergregory huntergregory added the cns Related to CNS. label Jan 8, 2025
@huntergregory
Copy link
Contributor Author

reopened after further investigation

@huntergregory huntergregory removed the cns Related to CNS. label Jan 8, 2025
@huntergregory huntergregory changed the title log: on crash, logs might not be sent to application insights log: [NPM] on crash, logs not sent to application insights Jan 8, 2025
@huntergregory huntergregory linked a pull request Jan 8, 2025 that will close this issue
Open
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
npm Related to NPM.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

fix: [NPM] close telemetry handler before crashing Azure/azure-container-networking
1 participant
@huntergregory