chore: change hard coded windows image versions to using the latest versions #5452
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
timmy-wright
requested review from
juan-lee,
cameronmeissner,
UtheMan,
ganeshkumarashok,
anujmaheshwari1,
AlisonB319,
Devinwong,
lilypan26,
AbelHu,
junjiezhang1997,
jason1028kr,
djsly,
phealy,
r2k1 and
zachary-bailey
as code owners
AbelHu
reviewed
Dec 18, 2024
| @@ -19,7 +19,7 @@ pr: | |||
| - vhdbuilder/packer/convert-sig-to-classic-storage-account-blob.sh | |||
| - vhdbuilder/packer/generate-vhd-publishing-info.sh | |||
| - vhdbuilder/packer/init-variables.sh | |||
| - vhdbuilder/packer/windows-image.env | |||
| - vhdbuilder/packer/windows-image.env.sh | |||
There was a problem hiding this comment.
Do you plan to release new AKS Windows images with non-security changes?
There was a problem hiding this comment.
The release is a separate process - but I do want to build them automatically.
There's also the need to set registry keys in the VHDs to enable any fixes for AKS. That'll have to be manual, sadly.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What type of PR is this?
/chore
What this PR does / why we need it:
It makes the AKS Windows VHD build automatically select the latest windows base image. This will ensure our daily windows builds and e2e tests are testing against the latest CVE fixes, etc. This is consistent with how we build Linux VHDs.
Requirements:
Special notes for your reviewer:
Release note: