-
Notifications
You must be signed in to change notification settings - Fork 211
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: containerd config registry host file to cse #5393
base: dev
Are you sure you want to change the base?
Conversation
1a460d1
to
f22e6c1
Compare
f22e6c1
to
d63bad7
Compare
d63bad7
to
52d4054
Compare
52d4054
to
d6d0782
Compare
d6d0782
to
fd0450b
Compare
fd0450b
to
c232872
Compare
@cameronmeissner Could you please have another round of review? The E2E failed due to quota issue. Should we skip it?
|
c232872
to
b898ee1
Compare
} | ||
When call configureContainerdRegistryHost | ||
The variable CONTAINERD_CONFIG_REGISTRY_HOST_MCR should equal '/etc/containerd/certs.d/mcr.microsoft.com/hosts.toml' | ||
The output should not equal "" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
can we assert on the tee
output to at least make sure the content is as expected?
we can skip this if the relevant scenarios have passed - please make sure to run once more before merging at least |
What type of PR is this?
/kind feature
What this PR does / why we need it:
Move the containerd config registry host file from custom data to the CSE provisioning scripts to make the scriptless/self-contained effort.
Which issue(s) this PR fixes:
Fixes #
Requirements:
Special notes for your reviewer:
Release note: