-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
ARO-9420: *: add acrpull controller, binding #1011
Open
stevekuznetsov
wants to merge
5
commits into
main
Choose a base branch
from
skuznets/acrpull
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
+939
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stevekuznetsov
requested review from
bennerv,
geoberle,
janboll,
weinong,
whober0521,
tony-schndr,
mbarnes,
SudoBrendan,
jmelis,
jonathan34c,
UlrichSchlueter,
jharrington22 and
zgalor
as code owners
December 19, 2024 15:23
stevekuznetsov
force-pushed
the
skuznets/acrpull
branch
from
December 19, 2024 15:39
d4d4a7a
to
21d7769
Compare
?? |
stevekuznetsov
force-pushed
the
skuznets/acrpull
branch
3 times, most recently
from
December 19, 2024 21:02
a234856
to
a6d978d
Compare
geoberle
reviewed
Dec 20, 2024
stevekuznetsov
force-pushed
the
skuznets/acrpull
branch
from
December 20, 2024 14:57
a6d978d
to
389987b
Compare
Please rebase pull request. |
stevekuznetsov
commented
Jan 7, 2025
acrpull/deploy/helm/acrpull/templates/validatingadmissionpolicybindings.yaml
Outdated
Show resolved
Hide resolved
geoberle
force-pushed
the
skuznets/acrpull
branch
from
January 8, 2025 10:04
389987b
to
6c8dfe4
Compare
Please rebase pull request. |
Signed-off-by: Steve Kuznetsov <[email protected]>
- updated msi pull controller to 0.1.7 - updated pull binding CRD for the additional workload identity fields - updated podmonitor to use the az apigroup (we don't have core prometheus CRDs installed) - updated VAP parameterNotFoundAction to `Allow` to mitigate a potential bug - updated servicegroup name in pipeline.yaml for acrpull - serialize image-puller MI federation setup (only one update at a time is supported) Signed-off-by: Gerd Oberlechner <[email protected]> Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
- updated msi pull controller to 0.1.7 - updated pull binding CRD for the additional workload identity fields - updated podmonitor to use the az apigroup (we don't have core prometheus CRDs installed) - updated VAP parameterNotFoundAction to `Allow` to mitigate a potential bug - updated servicegroup name in pipeline.yaml for acrpull - serialize image-puller MI federation setup (only one update at a time is supported) Signed-off-by: Gerd Oberlechner <[email protected]> Signed-off-by: Steve Kuznetsov <[email protected]>
Signed-off-by: Steve Kuznetsov <[email protected]>
stevekuznetsov
force-pushed
the
skuznets/acrpull
branch
from
January 8, 2025 19:55
6c8dfe4
to
3769232
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Supersedes #986