AnimationName selector #7288
AnimationName selector #7288
Conversation
| @@ -1,4 +1,5 @@ | |||
| // @flow | |||
| import { ProjectScopedContainersAccessor } from '../../InstructionOrExpression/EventsScope'; | |||
There was a problem hiding this comment.
Did you forget to revert this line?
There was a problem hiding this comment.
Regarding this, in the terminal where you ran npm start in newIDE/app, you should see a warning about this unused import, and VSCode might display the file with an orange color
newIDE/app/src/BehaviorsEditor/Editors/BehaviorPropertiesEditor.js
Outdated
Show resolved
Hide resolved
newIDE/app/src/BehaviorsEditor/Editors/BehaviorPropertiesEditor.js
Outdated
Show resolved
Hide resolved
newIDE/app/src/EventsBasedBehaviorEditor/EventsBasedBehaviorPropertiesEditor.js
Outdated
Show resolved
Hide resolved
| }, | ||
| getLabel, | ||
| getDescription, | ||
| getChoices, |
There was a problem hiding this comment.
I guess a new attribute isAllowingFreeText could be added and PropertiesEditor will only allow the current property value until we make a new component that does autocompletion one day.
A easier solution would be to add the default property value to the list but the extension creator may decide to change it and it may have side effects if some behaviors still have the old default value and it's not an existing animation either. But, I guess it will be rare enough.
What do you think about only adding the property default value to the list for now?
newIDE/app/src/BehaviorsEditor/Editors/BehaviorPropertiesEditor.js
Outdated
Show resolved
Hide resolved
newIDE/electron-app/yarn.lock
Outdated
There was a problem hiding this comment.
Could you revert those changes in yarn.lock? It's always a bit risky to update it if you're not sure about the changes
newIDE/app/src/CompactPropertiesEditor/PropertiesMapToCompactSchema.js
Outdated
Show resolved
Hide resolved
newIDE/app/src/EventsBasedBehaviorEditor/EventsBasedBehaviorPropertiesEditor.js
Outdated
Show resolved
Hide resolved
newIDE/app/src/EventsBasedBehaviorEditor/EventsBasedBehaviorPropertiesEditor.js
Outdated
Show resolved
Hide resolved
…opertiesEditor.js Co-authored-by: D8H <[email protected]>
| <SelectOption | ||
| key="property-type-animationname" | ||
| value="AnimationName" | ||
| label={t`Animation name (text)`} | ||
| /> |
There was a problem hiding this comment.
I wonder if it should be below the "Choice" type as it's a bit more specific.
…an/GDevelop into feat/animation-name-behaviors
The goal is to introduce a new property type in the extensions, 'AnimationName', for improved QoL for the end user. They no longer have to manually type the name of the animation. They have a selector based on the animations already created.
Currently, this is only available in the 'Behavior' panel in the object editing dialog box. I will add it to the left-side editing panel once this PR is approved.
https://gdevelop-storybook.s3.amazonaws.com/feat/animation-name-behaviors/latest/index.html?path=/story/eventsbasedbehavioreditor-eventsbasedbehavioreditordialog--default