Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature Request: Custom logo upload on top of supporting other formats (client/browser-side only, no file transmission, no backend) #328

Closed
KemingHe opened this issue Jul 27, 2024 · 2 comments

Comments

@KemingHe
Copy link
Contributor

Request Form

Hello @wei , I've been busy with a work production launch this past few month. Nevertheless, happy to keep supporting this project. #305 is still going, just a bit slowly.

New Feature Description

I want to make a request to add upload any image format for the logo on Socialify, see below:

Screenshot 2024-07-27 at 10 02 43 AM

Rationale

Currently ONLY .svg URL/URI is supported and some of us end-users don't have a web-hosted specifically .svg logo.

Plan

Since I'm still working on #305, (backwards comp-breaking bumps are kinda hard, tbh), for now, you can safely unassign me from #68.

Since this issue is my current major pain point, unless someone else really wants to take this, I can implement the image upload feature once I'm done with #305.

Let me know your thoughts!!

@wei
Copy link
Owner

wei commented Jul 30, 2024

Hi @KemingHe jpg/png is actually currently supported but not promoted to the users. The rationale behind this is they will often explode the size of the output image (as the image needs to be embedded in the final output as data uris) and also not optimal for large displays.

e.g. https://static.mlh.io/brand-assets/logo/official/mlh-logo-grayscale.png

https://socialify.git.ci/MLH-Fellowship/event-bot/image?description=1&font=Bitter&forks=0&issues=0&language=1&logo=https%3A%2F%2Fstatic.mlh.io%2Fbrand-assets%2Flogo%2Fofficial%2Fmlh-logo-grayscale.png&owner=0&pattern=Circuit%20Board&pulls=0&stargazers=0&theme=Light

Can you explain a bit more what you are thinking to do and what you mean by "(client/browser-side only, no file transmission, no backend)"?

@wei
Copy link
Owner

wei commented Sep 6, 2024

Closing due to inactivity, please feel free to reply whenever.

@wei wei closed this as not planned Won't fix, can't repro, duplicate, stale Sep 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants