Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Make jar function from request accessible #26

Open
chdanielmueller opened this issue Dec 25, 2015 · 6 comments
Open

Feature request: Make jar function from request accessible #26

chdanielmueller opened this issue Dec 25, 2015 · 6 comments

Comments

@chdanielmueller
Copy link

Hi,
Could you please make the jar function from request accessible?
https://github.com/request/request#requestjar
With this function it would be possible to create multiple cookie jars.
Thanks,
Daniel

@vesln
Copy link
Owner

vesln commented Dec 26, 2015

makes sense. wanna try to tackle it?

maybe we can simply yield the request object:

hippie().configure((request) => {
   const jar = request.jar();
   request.defaults({ jar });
   return request;
});

does this make sense? it also introduces a nice side effect which will enable people to replace the request module with something that has the same API.

@chdanielmueller
Copy link
Author

Hey @vesln
I tried my best but I didn't get it to work...
I rewrote my mocha tests to work around this issue.
Sorry that I was not able to contribute to your amazing project.
Keep up the good work.

@vesln
Copy link
Owner

vesln commented Feb 1, 2016

@chdanielmueller no worries! If there is anything I can do to help you implement it, please let me know!

@chdanielmueller
Copy link
Author

@vesln If you get the time to implement this by yourself it would be cool.
It's quite a workaround which I am using at the moment.

@vesln
Copy link
Owner

vesln commented Feb 2, 2016

I will add it to my queue.

@CacheControl would you be interested in giving this a try?

@CacheControl
Copy link
Collaborator

@vesln I'm currently in the middle of a couple projects and don't have much bandwidth, but I'll add it to my queue as well

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants