Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Flask py-autoreload stopped working on version 2.0.26 #2665

Open
gurpreetbhatoa opened this issue Sep 6, 2024 · 3 comments
Open

Flask py-autoreload stopped working on version 2.0.26 #2665

gurpreetbhatoa opened this issue Sep 6, 2024 · 3 comments

Comments

@gurpreetbhatoa
Copy link

I upgraded from uWSGI package from 2.0.23 to 2.0.26 and my flask development environment stopped doing hot reload on file changes. I tried it on 2.0.25 and still the same issue. I am running flask in docker on Win10 host. Docker desktop log comes up with the following error message:
"is taking too much time to die...NO MERCY"

I tried on version 2.0.24 and autoreload work in it. So issue seems like in version 2.0.25 onwards.

Could someone please check if this is the case?

@mjurosz
Copy link

mjurosz commented Oct 21, 2024

Update: Seem like another hot reloading issue regression in 2.0.27 is here #2681

In that case Linux, Docker, Python 3.12.6, Flask all works fine with Python uwsgi packages 2.0.24, 2.0.25.1. and 2.0.26. The regression is in 2.0.27.

Example

[uwsgi-python-reloader] module/file /myapp/app1.py has been modified
[uwsgi-python-reloader] module/file /myapp/app1.py has been modified

but then nothing happens.
I need to kill workers

Disposed connection pool after fork on pid:208 (worker:1)
Disposed connection pool after fork on pid:209 (worker:2)

manually from within Docker container to restart app

> docker compose exec myapp bash -c 'kill 208 ; kill 209'

and after that I finally see

...gracefully killing workers...
binary reloading uWSGI...

@xrmx
Copy link
Collaborator

xrmx commented Oct 28, 2024

Please retry with 2.0.28

@toabi
Copy link

toabi commented Oct 31, 2024

We have very weird behaviour with our django projects, even with 2.0.28 — it only recognises changes in certain files, but not all of them. I can't really find a pattern… it's just some files work and some don't.

We run it in a container and use docker-desktop (mac) to mount the code into the container… don't know if that also plays a role.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

4 participants