Refactor element-specific behavior out of ListModel #8212
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The issue was caused by the more button having a parent element with a `role="button"` resulting in the more button having a role of "presentation". To fix this, click handling was moved to a more button's sibling element (mail sender text). Close #8183
paw-hub
force-pushed
the
refactor-listmodel
branch
5 times, most recently
from
370a923 to
0526659
Compare
paw-hub
changed the title
Co-authored-by: paw-hub <[email protected]>
We do not want ListModel to specifically only work on ListElement types, or even element types in general. As such, we generalize it to a list of some kind of elements with some kind of ID, even if these are not types that would be stored remotely as part of the model. Co-authored-by: hrb-hub <[email protected]>
paw-hub
force-pushed
the
refactor-listmodel
branch
from
0526659 to
931b436
Compare
3 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.