Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Extension includes cookies from other extensions unrelated to youtube #42

Open
chrisliebaer opened this issue Jul 7, 2024 · 2 comments · May be fixed by #50
Open

Extension includes cookies from other extensions unrelated to youtube #42

chrisliebaer opened this issue Jul 7, 2024 · 2 comments · May be fixed by #50
Labels
help wanted Extra attention is needed

Comments

@chrisliebaer
Copy link

This issue might be somewhat related to #22

I'm using the extension https://github.com/Cookie-AutoDelete/Cookie-AutoDelete on Firefox.

When attempting to download a video with the extension, Tube Archivist fails with
cookie file is invalid: invalid Netscape format cookies file

And when inspecting the request I can see, that the Tube Archivist browser extension included the following cookie

www.youtube.com	TRUE	/<redacted-possibly-random-code>	FALSE	1751875552	CookieAutoDeleteBrowsingDataCleanup	CookieAutoDeleteBrowsingDataCleanup

So I'm no broser extension developer, I don't know if spilling into page cookies by Cookie AutoDelete is a good approach but I would also expect at least some extensions and user script to do the same.

I think it would be reasonable to filter out all cookies that don't match the format required by whatever tool generated the error message above, probably key=value.

@bbilly1
Copy link
Member

bbilly1 commented Jul 8, 2024

Well, it's not unrelated. It's a cookie for the domain www.youtube.com, so that is working as expected. Strange that this is invalid. Does removing that cookie make it work?

Ultimately, there is no expectation of compatibility with other extensions. If you want to make it compatible, please do.

@bbilly1 bbilly1 added the help wanted Extra attention is needed label Jul 8, 2024
@chrisliebaer
Copy link
Author

Removing the cookie either from the request or from the cookie store does make it work. Of course the other extension is adding it back after the next page request but everything done before that will work.

As I understand it, the error originates from yt-dlp? I sadly don't have the entire debug output anymore but I think the other cookies passed to tubearchivist all had a value of somekey=somevalue and this one didn't. I guess I have a look at it.

@chrisliebaer chrisliebaer linked a pull request Nov 26, 2024 that will close this issue
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants