-
Notifications
You must be signed in to change notification settings - Fork 4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Review me? #1
Comments
Thank you for your work. You're currently my only hope of having a functional vimperator-like user experience on FF58! Keep it up 👍 |
@cmcaine I see no feedback from Mozilla here. And saw you have updated code 15 days before. What is the latest progress about this api? Did Mozilla developers say something about it? |
@wnereiz Mozilla devs are busy with FF57, but Andy Mckay (webextensions team leader or something?) says he'll get mentors for our bugs soon. The meta bug (previously the bug mainly for the project in this repo) is: https://bugzilla.mozilla.org/show_bug.cgi?id=1215061 The key-sequence parser I'm developing for tridactyl will also go in the keyboard API to power the stopPropagation/preventDefault stuff. The bug for the shortcut API is here: https://bugzilla.mozilla.org/show_bug.cgi?id=1403295 On that last one you can see some complaints about how we intended to have the API work. We're blocked on the shortcut part of the API until they'll talk to us about it. |
@cmcaine I checked both bugs, and it is really a long story. I'll read the details later. Thank you very much for the efforts on it. |
Looks like the first step is finished (provide a way for an extension to update the shortcut for its command): https://bugzilla.mozilla.org/show_bug.cgi?id=1421811 |
Look at this (FF60) |
@aspel unfortunately, that's for Emacs style octopus commands (just look at the examples: https://developer.mozilla.org/en-US/Add-ons/WebExtensions/manifest.json/commands) rather than the vim-style sequence of commands, which is what we want, but this API makes no assumptions about what you want to do with the keys: The idea of this API is that we would be able to capture key events across the entire browser and send them to a background script. |
@cmcaine It is another year passed. I haven't see any progress on that. What is your comments on above commands API? Is it possible to be used for the addons like tridactyl? |
@kmaglione
Back in April I was talking to you a fair amount about this proposed API, and you said you'd be willing to review it when I'd gotten it to a reasonable state. Is that offer still open?
This is a simple first version with fairly limited functionality. I'd appreciate if you could take a look at it and see if I'm on the right tracks.
Thanks!
Comments from others also welcome :)
The text was updated successfully, but these errors were encountered: