Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Which tests should be required before merge? #320

Open
joshuagl opened this issue Jun 10, 2022 · 1 comment
Open

Which tests should be required before merge? #320

joshuagl opened this issue Jun 10, 2022 · 1 comment
Assignees
@MDr164
Labels
code health

Comments

@joshuagl
Copy link
Member

We have various checks we run on PR's:

  • CI/tests
  • DCO
  • Changeling
  • CodeQL

We just made DCO passing required for merges to main, should any other checks be required?
@MDr164
Copy link
Contributor

MDr164 commented Mar 7, 2024

In my opinion we should have DCO and unit tests passing required as a bare minimum. Pushing and merging broken code (e.g. something that doesn't pass tests) should not be allowed to be merged. Linting is debatable and so is CodeQL.

@MDr164 MDr164 moved this from Backlog to In Progress in go-tuf/v2 project planning Dec 17, 2024
@MDr164 MDr164 self-assigned this Dec 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@MDr164 MDr164

Labels
code health
Projects
go-tuf/v2 project planning
Status: In Progress
Milestone
No milestone
Development

No branches or pull requests
3 participants
@joshuagl @rdimitrov @MDr164