Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Deprecate rules no-export-load-in-svelte-module-in-kit-pages and valid-prop-names-in-kit-pages #901

Open
marekdedic opened this issue Nov 3, 2024 · 3 comments
Milestone

Comments

@marekdedic
Copy link
Contributor

marekdedic commented Nov 3, 2024

I was looking at these rules and wanted to move them to the "SvelteKit" section, but then I realized that maybe a better thing to do would be to deprecate them? It's a fix for a change that happened in August 2022, so it's probably no longer relevant...

What do you think?

@marekdedic marekdedic changed the title Deprecate rule no-export-load-in-svelte-module-in-kit-pages Deprecate rules no-export-load-in-svelte-module-in-kit-pages and valid-prop-names-in-kit-pages Nov 3, 2024
@ota-meshi
Copy link
Member

Hmm... Those rules aren't useful for normal use, but they can be useful for users doing migrations.
How about having a new section like Migration?

@marekdedic
Copy link
Contributor Author

The migrations are from version 2 years old... I think people doing such migrations won't be on v3 of this plugin :D I think it'd be safe to deprecate them in v3 and remove in v4.

Otherwise, creating a new category seems a good alternative. Or we can just move them under SvelteKit

@baseballyama baseballyama added this to the v3 milestone Jan 1, 2025
@baseballyama
Copy link
Member

If we merge #980, we can automatically apply the rule if a user uses older SvelteKit.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants