Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature request: Add CI support #55

Open
efimk-lu opened this issue Oct 27, 2018 · 3 comments
Open

Feature request: Add CI support #55

efimk-lu opened this issue Oct 27, 2018 · 3 comments

Comments

@efimk-lu
Copy link

Part of a standard CI flow is to verify that a package size did not cross a certain threshold. Right now due to the way the results are outputted it's cumbersome to extract and assert the final package size value.

Suggested solution:
Adding a new command line option, e.g. assert-smaller if the resulting package size is higher than the given number then fail with exit code different than 0.

@alshakero
Copy link
Collaborator

I think you're looking for this package https://github.com/siddharthkp/bundlesize

@efimk-lu
Copy link
Author

But, it means I have to package it on my own, right ? I like cost-of-modules approach, just run and it works :-)

@siddharthkp
Copy link
Owner

Hey @efimk-lu, not sure if this is right tool

cost-of-modules does not look at your bundle size, it looks at the node_modules size

more here: https://github.com/siddharthkp/cost-of-modules#motivation

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants