Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Validate IsAnalyzerSuppressed is needed #147

Open
rjmurillo opened this issue Jul 8, 2024 · 0 comments
Open

Validate IsAnalyzerSuppressed is needed #147

rjmurillo opened this issue Jul 8, 2024 · 0 comments
Assignees
@rjmurillo
Labels
analyzers Change that impacts an analyzer behavior help wanted triage
Milestone
vNext

Comments

@rjmurillo
Copy link
Owner

It feels like this code shouldn't be needed? I haven't gotten to the usage yet, but assuming we do need this, it feels like we should file + link a bug against Roslyn.
Originally posted by @MattKotsenas in #140 (comment)

The code is added to ensure the rule does not fire when it would otherwise be suppressed. Additional test cases / test harness work is required to support this programmatically.

This can be verified quickly with a prototype. If it does need to be there, an explainer why plus Matt's suggestion can be done.
@rjmurillo rjmurillo mentioned this issue Jul 8, 2024
Merged
@rjmurillo rjmurillo self-assigned this Jul 8, 2024
@rjmurillo rjmurillo added this to the v0.2.0 milestone Jul 8, 2024
@rjmurillo rjmurillo added help wanted analyzers Change that impacts an analyzer behavior labels Jul 8, 2024
@rjmurillo rjmurillo modified the milestones: v0.2.0, vNext Oct 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rjmurillo rjmurillo

Labels
analyzers Change that impacts an analyzer behavior help wanted triage
Projects
None yet
Milestone
vNext
Development

No branches or pull requests
1 participant
@rjmurillo