Skip to content
This repository has been archived by the owner on Mar 7, 2024. It is now read-only.

bug: use the correct format for "expires" (should not include milliseconds) #22

Closed
rdimitrov opened this issue Feb 28, 2023 · 3 comments
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed

Comments

@rdimitrov
Copy link
Owner

No description provided.

@rdimitrov rdimitrov converted this from a draft issue Feb 28, 2023
@rdimitrov rdimitrov changed the title Should we include milliseconds in the expiration format chore: Clarify format for Expire, should we include milliseconds Feb 28, 2023
@jku
Copy link

jku commented Dec 11, 2023

The way I've read the spec is that fractions are not allowed and IIRC python-tuf API strips them out when expiry is set and does not accept fractions when deserializing JSON (but I could be wrong on the last bit)

@rdimitrov
Copy link
Owner Author

Thanks! Apparently we have to update the way we format and store this then 👍

I checked root-signing and I see that at some point go-tuf was generating metadata like that -

https://github.com/sigstore/root-signing/blob/ca9c5644c3217886b543265bacea774351bc0bde/repository/repository/1.root.json#L27C3-L27C3

but eventually it switched to -

https://github.com/sigstore/root-signing/blob/ca9c5644c3217886b543265bacea774351bc0bde/repository/repository/root.json#L6.

I'll update the issue's title so we can track this fix here 👍

@rdimitrov rdimitrov changed the title chore: Clarify format for Expire, should we include milliseconds bug: use the correct format for "expires" (should not include milliseconds) Dec 11, 2023
@rdimitrov rdimitrov added bug Something isn't working help wanted Extra attention is needed good first issue Good for newcomers labels Dec 11, 2023
@rdimitrov
Copy link
Owner Author

closing in favour of theupdateframework/go-tuf#596

@github-project-automation github-project-automation bot moved this from Todo to Done in go-tuf-metadata Jan 31, 2024
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
bug Something isn't working good first issue Good for newcomers help wanted Extra attention is needed
Projects
Status: Done
Development

No branches or pull requests

2 participants