-
Notifications
You must be signed in to change notification settings - Fork 2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add a GitHub Action to build book? #1458
Comments
This check should be done by asciidoctor itself, and running the compilation on GitHub Actions instead of Travis (presently) will not change anything. Please note that presently, the book is built by travis on all branches and pull requests. This is mainly an issue with asciidoctor which raises no warnings/errors when not processing correctly an image. |
Aah, of course the book is build (by Travis). Sorry. |
Having just gone through this at |
I already excused myself that I have forgotten that there was the Travis CI. And then of course there is no need to replace it with GitHub Actions. The missing info was that the builds are auto-published. Thank you guys!! |
I am not sure about my request so opinions are welcome.
How about adding a GitHub Action to build the HTML and PDF output on commits which are then somehow/somewhere available to others, so also the (real) results can be checked?
I have no clue if this is possible for AsciiDoctor files and how that would be done. But I know, that this can be done for LaTeX files. A quick search for a starting point on AsciiDoctor Actions revealed
Maybe there is something useful in it.
Background:
In the German book it was found that some figures where not shown in the PDF output (only) (see progit/progit2-de#113) I guess most of the contributors don't have AsciiDoctor installed and "just" use the preview, so not all details like that PDF checking can be done quickly/easily.
The text was updated successfully, but these errors were encountered: