Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Typo in p5.Shader() documentation code snippet #7456

Open
1 of 17 tasks
VSvensli opened this issue Jan 4, 2025 · 2 comments · May be fixed by #7458
Open
1 of 17 tasks

Typo in p5.Shader() documentation code snippet #7456

VSvensli opened this issue Jan 4, 2025 · 2 comments · May be fixed by #7458

Comments

@VSvensli
Copy link

VSvensli commented Jan 4, 2025

Most appropriate sub-area of p5.js?

  • Accessibility
  • Color
  • Core/Environment/Rendering
  • Data
  • DOM
  • Events
  • Image
  • IO
  • Math
  • Typography
  • Utilities
  • WebGL
  • Build process
  • Unit testing
  • Internationalization
  • Friendly errors
  • Other (specify if possible)

p5.js version

v1.11.2

Web browser and version

No response

Operating system

No response

Steps to reproduce this

Steps:

  1. Typo on line /src/webgl/p5.Shader.js_L49

There is a misplaced space.

Change
// Add the rest ofy our shader code here!

To
// Add the rest of your shader code here!

@VSvensli VSvensli added the Bug label Jan 4, 2025
Copy link

welcome bot commented Jan 4, 2025

Welcome! 👋 Thanks for opening your first issue here! And to ensure the community is able to respond to your issue, please make sure to fill out the inputs in the issue forms. Thank you!

@ImRAJAS-SAMSE ImRAJAS-SAMSE linked a pull request Jan 6, 2025 that will close this issue
3 tasks
@ImRAJAS-SAMSE
Copy link

Hi, I've opened a pull request (#7458) to address this issue by fixing the typo in the p5.Shader.js documentation comment. Please let me know if any additional changes are needed. Thank you!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants