Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Generic text box support #20

Open
nickserv opened this issue Oct 11, 2019 · 5 comments
Open

Generic text box support #20

nickserv opened this issue Oct 11, 2019 · 5 comments
Labels
enhancement New feature or request help wanted Extra attention is needed
Milestone

Comments

@nickserv
Copy link
Member

Other extensions like prettier-js-extension allow any text box to be used for formatting, which would help make this extension more useful with less code changes. I still think some of the functionality and UI specific to GitHub and Stack Overflow could be useful though.

@lipis
Copy link
Member

lipis commented Oct 11, 2019

Yes, when you clicking on the Prettier button from the toolbar, and if the focus is inside a textarea it should probably format it.

@kaicataldo
Copy link
Member

Out of curiosity, how do we want to handle detecting the parser? Just naively assume it's Markdown? I wonder if the we could have a dropdown list when clicking the Prettier button in the toolbar that says Format as... and then has a list of langs we're supporting?

@nickserv
Copy link
Member Author

Good question, maybe we could use a language detection library and fall back to Markdown when it's unknown or looks like snippets from multiple languages.

@kaicataldo
Copy link
Member

Ohhh I like that idea :)

@kaicataldo kaicataldo added enhancement New feature or request help wanted Extra attention is needed labels Oct 15, 2019
@nickserv nickserv added this to the MVP milestone Oct 17, 2019
@nickserv nickserv modified the milestones: 1.0, 2.0 Nov 14, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
enhancement New feature or request help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants