Inability to adjust UI scale key bindings is not intuitive

[abraker95]

Type

Game behaviour

Bug description

I want to change mania scroll speed key bindings to ctrl+= and ctrl+- like I have them in stable. It lets me even though that is mapped to UI scale adjustment. I don't see the UI scale adjustment binding config in settings, and it is taking precedence over the mania scroll speed bindings I set.

Expected behavior:

• Selection should warn that ctrl+= and ctrl+- key bindings have something already set it
• Ability to change UI scale adjustment key bindings

Screenshots or videos

No option to change UI scale keybinding when searching for it:

I was able to set key bindings for scollspeed to ctrl+- and ctrl+= despite that being mapped to UI scaling adjustment

Version

2024.1224.1-lazer

Logs

compressed-logs.zip

[bdach]

The scale keybinds are not adjustable because they are bound to "platform actions" added in ppy/osu-framework#4816 which are not supposed to rebindable. This was pointed out during review of that series of changes but the resolution ended up being moving the scroll speed defaults to different buttons.

@Joehuu @peppy please advise how to proceed

[frenzibyte]

Adding my two cents here, binding a game-wide action such as changing UI scale to a common modifier such as Control feels odd in itself. I would personally be in favour of defining custom actions for this and map it by default to Alt+Plus and Alt+Minus (or any other less-common modifier).

[Joehuu]

When I made those PRs, I was following what browsers and other apps like Discord that didn't allow rebinding. I totally disregarded games.

After looking for games with UI scale, I can only find Factorio. That game defaults to only Ctrl + Numpad +/-/0 (not number row) and is rebindable.

So I would make them rebindable. Unsure of the default changing.

[peppy]

At very least, user configured keys may want to override platform keys. If that's not easy to achieve (or not the global bheaviour we want) then redefining these keys locally is probably fine. Just keep in mind they should have different defaults per platform, maybe sourced from the platform bindings' defaults.