Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable edit actions on save screen #10658

Open
danieldegroot2 opened this issue Jan 7, 2025 · 0 comments
Open

Disable edit actions on save screen #10658

danieldegroot2 opened this issue Jan 7, 2025 · 0 comments

Comments

@danieldegroot2
Copy link
Contributor

danieldegroot2 commented Jan 7, 2025

URL

No response

How to reproduce the issue?

  • Disallow adding nodes to ways on save screen (prevent accidental redundant nodes)
  • Cancel dragging on save (prevent accidental drag); note, completing drag on active view edge causes infinite map view drag.
    (while dragging, use Ctrl+S to go to the save screen)

There might be other actions which are undesirable.
Rapid does not allow these actions on save, but completes -not cancels- drag, resulting in accidental drag.

See also #10593 (only the action where node is still 'hovering' -not placed down yet- should be cancelled, not the whole line)

Screenshot(s) or anything else?

Infinite map view drag (node is placed down but stuck to sidebar, map view is stuck moving, even with save cancelled, ESC, Ctrl+Z..
Only happens while in save screen.
image

Which deployed environments do you see the issue in?

Released version at openstreetmap.org/edit, Development version at ideditor.netlify.app, RapiD version at mapwith.ai/rapid

What version numbers does this issue effect?

2.30.4, 2.31.0-dev, RapiD 2.5.0

Which browsers are you seeing this problem on?

Chrome

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

1 participant