Warn when addr:*=* is added to a relation

[gy-mate]

Description

addr:*=* tags are not allowed on relations (except multipolygon relations):

• https://wiki.openstreetmap.org/wiki/Key:addr:*#:~:text=Used%20on%20these%20elements
• https://wiki.openstreetmap.org/wiki/Talk:Key:addr:*#on_relations

Therefore, I think that iD should warn users when this "rule" isn't met.

Screenshots

N/A

[maro-21]

Technically they can be added to relations, e.g. a building with an address in the relation type=multipolygon. Unless iD excludes only this relation.

onRelation=no on OSM Wiki means "on relations except multipolygon relations".

[gy-mate]

onRelation=no on OSM Wiki means "on relations except multipolygon relations".

Yeah, I meant it like that.

[tyrasd]

To some extent this is already addressed by the presets: presets for non-multipolygon relations should not have an address field. So only users who are using the raw tag editor should be affected and those users should be aware of the tagging rules. 😉 That said, it wouldn't hurt to add a validation rule for this, if someone wants to give it a shot.

[gy-mate]

So only users who are using the raw tag editor should be affected

Or JOSM users, like here. :)

those users should be aware of the tagging rules. 😉

Yeah, they should be, but unfortunately some make this mistake:

And a warning in iD would help with cleaning up this mess.

[gy-mate]

it wouldn't hurt to add a validation rule for this, if someone wants to give it a shot.

@tyrasd I've found this list:

iD/modules/osm/tags.js

Lines 270 to 278 in b2b397c

	export var osmMutuallyExclusiveTagPairs = [
	['noname', 'name'],
	['noref', 'ref'],
	['nohousenumber', 'addr:housenumber'],
	['noaddress', 'addr:housenumber'],
	['noaddress', 'addr:housename'],
	['noaddress', 'addr:unit'],
	['addr:nostreet', 'addr:street']
	];

However, this only specifies keys. And this validation rule should be like:

['type!=multipolygon', 'addr:housenumber'],
['type!=multipolygon', 'addr:housename'],

etc.

Is it possible to add these to an existing list? If not, could you please point me to the right direction?

Thank you in advance!

[Avan2021]

Can you please assign this issue to me if it is still open? I'd love to work on it.

[gy-mate]

@Avan2021 I don't have that option but you can work on it anyway!

[Avan2021]

@gy-mate do you think adding a new condition to osmMutuallyExclusiveTagPairs like
['type!=multipolygon', 'addr:housename'] mentioned above will be a good approach

[tyrasd]

🤔 Maybe let's step back a little bit before starting to work on it right away.

The thing with validations/warnings in iD is that they are not primarily meant to be a method to "clean up OSM data". Especially if the issues are primarily caused by (users of) other editors, these warnings could even be confusing and irritating for users of iD. iD tries to abstract away complicated concepts like relations wherever possible (e.g. by presets), so coming up with an easy to understand validation message would be critical if we want to add one in iD. An additional complication is that validation warnings in iD should be actionable. This is typically done by providing buttons to directly solve the issue: For example, the osmMutuallyExclusiveTagPairs warning offers the user to remove either of the two mutually exclusive tags. In the case of address tags on a relation, the potential fixes are quite varying (from removing the address tags, to extracting the address information into a dedicated address node, to changing the type of the relation, etc.), which again would be hard to understand for newcomers to OSM.

So, wouldn't it make more sense to tackle this problem on a different level: If this case would be included in a quality assurance tool like osmose, then it would be more generally visible than a validation warning only in iD, it would be more targeted as new users would not be "bothered", and experienced users could also get these warnings in iD by enabling the respective QA layer.