-
Notifications
You must be signed in to change notification settings - Fork 111
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Latest image will not build on ARM architechture #1751
Comments
Was able to reproduce this. Wonder if upgrading to the latest |
Just coming back to note that upgrading to 24.09 (and to the 25 rc) does not alleviate this issue. Also I tried installing on t4g + c7g instances (gravitron 2 + 3) to confirm reproduction. I initially thought it was a cpu feature issue (specifically SVE), but since c7g supports SVE and still doesn't compile I'm once again out of ideas. |
Just built spdk from source on the gravitron 3 arm chip and it works great + passes unit tests (rev. e01cb43). Seems like an issue in the build pipeline. Don't know nix that well, but I'll start digging into that I guess! |
Could be something to do with our build flags. |
Just fixed the nix shell for arm in |
1796: fix: proper to_ptr type cast to c_char r=tiagolobocastro a=maxwnewcomer ## Platform agnostic `c_char` type casting Instead of hard-casting to `i8` or `u8` we can just cast to the built in `std::os::raw::c_char`. This change allows for full `arm64` compilation of mayastor. ### Related - Fixes #1795 - Part of the fix to #1751 (not including `spdk-rs` changes) Co-authored-by: Max Newcomer <[email protected]>
Describe the bug
If I check-out the code in the release/v2.7.0 branch, the code compiles correctly on an ARM based system.
If I check-out the develop or staging branches, the code will not compile on an ARM based system with the following errors:
build_log.txt
Develop branch will build successfully on an amd64 based system.
To Reproduce
Grab an ARM computer (Raspberry Pi 5, Ampere Altra, etc).
Check out the develop branch.
Run "./scripts/release.sh --skip-publish"
Expected behavior
Image builds successfully.
Screenshots
If applicable, add screenshots to help explain your problem.
** OS info (please complete the following information):**
The text was updated successfully, but these errors were encountered: