Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] DefinitelyTyped npmcli__arborist does not match internal arborist.loadActual(options) #238

Closed
1 task done
ghiscoding opened this issue Jul 4, 2024 · 2 comments
Closed
1 task done
Labels
Bug thing that needs fixing Needs Triage needs an initial review

Comments

@ghiscoding
Copy link

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

The DefinitelyTyped npmcli__arborist is not matching the actual options from arborist.loadActual(options)

https://github.com/npm/cli/blob/6f33d74f310fa27aad30fd00d58d8e4404ef8cb2/workspaces/arborist/lib/arborist/load-actual.js#L98-L107

it seems that none of the options matches what is available from DefinitelyTyped npmcli__arborist referenced below
https://github.com/DefinitelyTyped/DefinitelyTyped/blob/3c78f0fd3c1bd7c16bde2b58e3dccadfccbdb0f1/types/npmcli__arborist/index.d.ts#L31-L79

Expected Behavior

DefinitelyTyped npmcli__arborist should match these options but it does not

https://github.com/npm/cli/blob/6f33d74f310fa27aad30fd00d58d8e4404ef8cb2/workspaces/arborist/lib/arborist/load-actual.js#L98-L107

Steps To Reproduce

  1. all environments
  2. install @npmcli/arborist and @types/npmcli__arborist
  3. try to use existing option(s), for example { ignoreMissing: true }
  4. See error print screen below

image

Environment

  • npm: v10.1.0
  • Node.js: v20.9.0
  • OS Name: Windows 10
  • System Model Name:
@ghiscoding ghiscoding added Bug thing that needs fixing Needs Triage needs an initial review labels Jul 4, 2024
@ghiscoding ghiscoding changed the title [BUG] <title> [BUG] DefinitelyTyped npmcli__arborist does not match internal arborist.loadActual(options) Jul 4, 2024
@ghiscoding
Copy link
Author

ghiscoding commented Jul 4, 2024

this is also related to the issue #225

@wraithgar
Copy link
Member

You should bring this up in the definitelytyped repo. That is not managed by npm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug thing that needs fixing Needs Triage needs an initial review
Projects
None yet
Development

No branches or pull requests

2 participants