Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implement Server Side Sorting #1506

Open
blizzz opened this issue Dec 16, 2024 · 0 comments
Open

Implement Server Side Sorting #1506

blizzz opened this issue Dec 16, 2024 · 0 comments
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request performance Performance issues and optimisations

Comments

@blizzz
Copy link
Member

blizzz commented Dec 16, 2024

Contributes to #941

For Views we can have filters and sorting, as well as dynamically in the web interface. In order to be able to return paginated results, we have to be able to also sort on server side. While filtering is implemented there, sorting is still an open todo. Cf.

public function findAll(array $tableColumns, array $columns, int $tableId, ?int $limit = null, ?int $offset = null, ?array $filter = null, ?array $sort = null, ?string $userId = null): array {
$this->setColumns($columns, $tableColumns);
$columnIdsArray = array_map(fn (Column $column) => $column->getId(), $columns);
$wantedRowIdsArray = $this->getWantedRowIds($userId, $tableId, $filter, $limit, $offset);
// TODO add sorting
return $this->getRows($wantedRowIdsArray, $columnIdsArray);
}

@blizzz blizzz added 1. to develop Accepted and waiting to be taken care of enhancement New feature or request performance Performance issues and optimisations labels Dec 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
1. to develop Accepted and waiting to be taken care of enhancement New feature or request performance Performance issues and optimisations
Projects
None yet
Development

No branches or pull requests

1 participant