Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add settings and menu items to toggle display of each section #71

Merged

Conversation

andrewfulton9
Copy link
Collaborator

Reference Issues or PRs

closes #10
Adds settings for which sections to show.

jlab-launchpad-issue10.mp4

What does this implement/fix?

Put a x in the boxes that apply

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds a feature)
  • Breaking change (fix or feature that would cause existing features not to work as expected)
  • Documentation Update
  • Code style update (formatting, renaming)
  • Refactoring (no functional changes, no API changes)
  • Build related changes
  • Other (please describe):

Testing

  • Did you test the pull request locally?
  • Did you add new tests?

Documentation

Access-centered content checklist

Text styling

  • The content is written with plain language (where relevant).
  • If there are headers, they use the proper header tags (with only one level-one header: H1 or # in markdown).
  • All links describe where they link to (for example, check the Nebari website).
  • This content adheres to the Nebari style guides.

Non-text content

  • All content is represented as text (for example, images need alt text, and videos need captions or descriptive transcripts).
  • If there are emojis, there are not more than three in a row.
  • Don't use flashing GIFs or videos.
  • If the content were to be read as plain text, it still makes sense, and no information is missing.

Any other comments?

Copy link
Contributor

Binder 👈 Launch a Binder on branch andrewfulton9/jupyterlab-new-launcher/issue10/shown_sections_configuration

@krassowski
Copy link
Member

Test failure (Parsed an error from text content: undefined RangeError: Incorrect locale information provided) is unrelated: jupyterlab/jupyterlab#17079

Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Neat! See some minor comments

schema/plugin.json Outdated Show resolved Hide resolved
src/commands.ts Outdated
return settings.composite
.createEmptySection as ISettingsLayout['createEmptySection'];
},
label: trans.__('Show Create Empty Section'),
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Same remark about adding quotes for labels.

src/commands.ts Outdated Show resolved Hide resolved
src/launcher.tsx Outdated Show resolved Hide resolved
andrewfulton9 and others added 4 commits December 12, 2024 10:40
@andrewfulton9
Copy link
Collaborator Author

@krassowski, thanks for the review! I updated all the settings text to properly reflect the actual section headers. Let me know if there is anything else I should do to close out this PR.

@krassowski
Copy link
Member

JupyterLab 4.3.4 fixed the issue with "Incorrect locale information provided", I restarted the tests - let's see if everything passes.

@krassowski
Copy link
Member

It looks like query strings in the visual regression test code need updating?

@andrewfulton9
Copy link
Collaborator Author

@krassowski, I'm not sure why the table-context-menu is failing.
actual:
table-context-menu-actual
vs
expected:
table-context-menu-expected

Should I go ahead and update the images here anyway?

@krassowski
Copy link
Member

yes, let's update them: bot please update snapshots

@krassowski krassowski closed this Dec 19, 2024
@krassowski krassowski reopened this Dec 19, 2024
@krassowski krassowski changed the title Issue10/shown sections configuration Add settings and menu items to toggle display of each section Dec 19, 2024
src/commands.ts Outdated Show resolved Hide resolved
@krassowski
Copy link
Member

bot please update snapshots

@krassowski krassowski closed this Dec 19, 2024
@krassowski krassowski reopened this Dec 19, 2024
Copy link
Member

@krassowski krassowski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @andrewfulton9!

@krassowski krassowski removed the needs: review 👀 This PR is complete and ready for reviewing label Dec 19, 2024
@krassowski krassowski merged commit 101cafe into nebari-dev:main Dec 19, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow to toggle which sections to show?
2 participants