-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add settings and menu items to toggle display of each section #71
Add settings and menu items to toggle display of each section #71
Conversation
Test failure ( |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Neat! See some minor comments
src/commands.ts
Outdated
return settings.composite | ||
.createEmptySection as ISettingsLayout['createEmptySection']; | ||
}, | ||
label: trans.__('Show Create Empty Section'), |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Same remark about adding quotes for labels.
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
Co-authored-by: Michał Krassowski <[email protected]>
@krassowski, thanks for the review! I updated all the settings text to properly reflect the actual section headers. Let me know if there is anything else I should do to close out this PR. |
JupyterLab 4.3.4 fixed the issue with "Incorrect locale information provided", I restarted the tests - let's see if everything passes. |
It looks like query strings in the visual regression test code need updating? |
@krassowski, I'm not sure why the table-context-menu is failing. Should I go ahead and update the images here anyway? |
yes, let's update them: bot please update snapshots |
bot please update snapshots |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @andrewfulton9!
Reference Issues or PRs
closes #10
Adds settings for which sections to show.
jlab-launchpad-issue10.mp4
What does this implement/fix?
Put a
x
in the boxes that applyTesting
Documentation
Access-centered content checklist
Text styling
H1
or#
in markdown).Non-text content
Any other comments?