Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Lack of a "proper" Github Action prevents pinning to specific versions as hardening advice recomments. #820

Open
blowdart opened this issue Dec 3, 2024 · 2 comments
Labels
tabled We like this idea, but we are not going to action on it in the moment

Comments

@blowdart
Copy link

blowdart commented Dec 3, 2024

Best practice in actions these days is to pin an action to its sha commit number. This prevents problems when an attacker compromises an action and releases a newer version with dodgy code.

The github actions instructions show there's no marketplace action at all for the SBOM tool, which means you can't follow the recommended best practices for third party actions.

The instructions to just curl down the latest release present the same risk that pinning an action would avoid (assuming any action you publish also downloads a specific version, rather than just latest).

While you could reduce the risk by having sbom generation run in a separate action, and upload its own artifact that way this is a bunch of work for a lot of people which could be avoid if you'd publish a marketplace action instead. Additionally, an action would also tie into dependabot nicely, giving users a notification, and appropriate PR when a new version is published.

@jlperkins jlperkins added needs triage Default status upon issue submission tabled We like this idea, but we are not going to action on it in the moment and removed needs triage Default status upon issue submission labels Dec 3, 2024
@jlperkins
Copy link
Contributor

Thank you for pointing this out. We agree with your findings, but will not action on this yet. If our GitHub Action becomes higher priority for us in the future, we may choose to take this work on.

@Shorifi
Copy link

Shorifi commented Dec 8, 2024

          - name: SPDX Dependency Submission Action
            uses: advanced-security/[email protected]

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
tabled We like this idea, but we are not going to action on it in the moment
Projects
None yet
Development

No branches or pull requests

3 participants