-
Notifications
You must be signed in to change notification settings - Fork 141
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Timeout when fetching license information #584
Comments
I'm facing the same issue in what I'd consider a small project (102 components in total, 27 explicitly referenced).
But it would also increase the risk of hitting the documented rate limits, so all things considered, I think a configurable timeout would be the best solution. EDIT: I tried to make a PR about this, but can't build the solution, see #687. |
Same here. But I don't know the root cause for the timeout. Very large project. |
We have a project with 121 components that times out every single time. Please make this configurable. |
I've submitted a PR that adds a CLI argument to configure this. |
PR is #773. |
…gument (#584) (#773) * Made the Timeout in LicenseInformationService configurable via CLI argument (#584) * Added recommended fixes for PR #773 - Renamed variables to specify Seconds - Added new CLI arg -lto to docs - Added support for negative values for -lto - Added tests for limits of -lto - Fixed breaking API change by creating new Interfaces - Changed some magic numbers to constants instead - Added some Warning statements * Added additional recommended fixes for PR #773 - Fixed a couple of minor bugs - Reduced valid input range for -lto to 1-86400 - Moved MaxTimeout and DefaultTimeout to Constants class --------- Co-authored-by: Dave Tryon <[email protected]>
The timeout of 30 seconds is a bit too short for larger projects:
Would it be possible to increase the timeout or have a configuration option?
sbom-tool/src/Microsoft.Sbom.Api/Executors/LicenseInformationService.cs
Line 23 in 0b4db48
sbom-tool/src/Microsoft.Sbom.Api/Executors/LicenseInformationService.cs
Line 41 in 0b4db48
The text was updated successfully, but these errors were encountered: