[js/node] add proxy agent support for onnxruntime-node install script #23232
Conversation
|
@microsoft-github-policy-service agree |
|
Hi @jnzw, thank you for contributing! I don't know much details about proxy agent. There was a PR #22537 which does similar things to onnxruntime-web, but using a different package |
|
Hi @fs-eire, I tried |
Thank you. Considering undici is not a small package, and we have to put it as a runtime dependency instead of a dev dependency (because it's a part of install script), I made PR #23242 to replace |
Signed-off-by: Junze Wu <[email protected]>
jnzw
force-pushed
the
fix/node-install-proxy
branch
from
c0e0d81 to
9d2f42a
Compare
|
Thanks, I've rebased and switched to use |
### Description Use `https.get` instead of `fetch` in ORT Nodejs binding package install script. ### Motivation and Context According to discussions in #23232, the package `global-agent` cannot work with `fetch` API. To make it work with the proxy agent, this PR replaces the `fetch` API with `https.get` in the install script.
|
/azp run Windows ARM64 QNN CI Pipeline,Windows x64 QNN CI Pipeline,Windows CPU CI Pipeline,Windows GPU CUDA CI Pipeline,Windows GPU DML CI Pipeline,Windows GPU Doc Gen CI Pipeline,Windows GPU TensorRT CI Pipeline,ONNX Runtime Web CI Pipeline,Linux CPU CI Pipeline,Linux CPU Minimal Build E2E CI Pipeline |
|
/azp run Linux GPU CI Pipeline,Linux GPU TensorRT CI Pipeline,Linux OpenVINO CI Pipeline,Linux QNN CI Pipeline,MacOS CI Pipeline,orttraining-linux-ci-pipeline,orttraining-linux-gpu-ci-pipeline,onnxruntime-binary-size-checks-ci-pipeline,Big Models,Linux Android Emulator QNN CI Pipeline |
|
/azp run Android CI Pipeline,iOS CI Pipeline,ONNX Runtime React Native CI Pipeline,CoreML CI Pipeline,Linux DNNL CI Pipeline,Linux MIGraphX CI Pipeline,Linux ROCm CI Pipeline |
|
Azure Pipelines successfully started running 7 pipeline(s). |
|
Azure Pipelines successfully started running 8 pipeline(s). |
|
Azure Pipelines successfully started running 10 pipeline(s). |
fs-eire
changed the title
Description
Add proxy agent to fetch request
Motivation and Context
Fixes #23231