Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

custom op's SUPPORTED_TENSOR_TYPES does not include int4 and uint4 #23205

Open
BoarQing opened this issue Dec 27, 2024 · 0 comments
Open

custom op's SUPPORTED_TENSOR_TYPES does not include int4 and uint4 #23205

BoarQing opened this issue Dec 27, 2024 · 0 comments
Labels
ep:VitisAI issues related to Vitis AI execution provider

Comments

@BoarQing
Copy link
Contributor

BoarQing commented Dec 27, 2024

Describe the issue

We implemented VitisAI custom ops' that support all tensor types by returning ONNX_TENSOR_ELEMENT_DATA_TYPE_UNDEFINED when GetInputType() is called. But if the input contains int4 tensor it would fail here.

Status status(ONNXRUNTIME, INVALID_GRAPH,
"This is an invalid model. "
"Type Error: Type '" +
*input_type + "' of input parameter (" + input_def->Name() +
") of operator (" + op.Name() + ") in node (" + node_name + ") is invalid.");
return status;

#23204 should fix this issue.

To reproduce

Create a custom op that return ONNX_TENSOR_ELEMENT_DATA_TYPE_UNDEFINED when GetInputType() is called and add an input tensor of int4.

Urgency

No response

Platform

Windows

OS Version

Windows 11

ONNX Runtime Installation

Built from Source

ONNX Runtime Version or Commit ID

main

ONNX Runtime API

C++

Architecture

X64

Execution Provider

Vitis AI

Execution Provider Library Version

No response

@github-actions github-actions bot added the ep:VitisAI issues related to Vitis AI execution provider label Dec 27, 2024
jywu-msft pushed a commit that referenced this issue Jan 2, 2025
### Description
<!-- Describe your changes. -->
Changed all support tensor  type from ir 9 to ir 10.


### Motivation and Context
<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
- See issue #23205

Co-authored-by: Yueqing Zhang <[email protected]>
TedThemistokleous pushed a commit to ROCm/onnxruntime that referenced this issue Jan 3, 2025
…t#23204)

<!-- Describe your changes. -->
Changed all support tensor  type from ir 9 to ir 10.

<!-- - Why is this change required? What problem does it solve?
- If it fixes an open issue, please link to the issue here. -->
- See issue microsoft#23205

Co-authored-by: Yueqing Zhang <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ep:VitisAI issues related to Vitis AI execution provider
Projects
None yet
Development

No branches or pull requests

1 participant