New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

text unit sources are not deduplicated #1467

Open

volksen opened this issue Dec 4, 2024 · 1 comment

Contributor

volksen commented Dec 4, 2024 •

edited

Loading

Hello,

when creating the text unit sources in the LocalSearchMixedContext, the sources are not deduplicated:

While there is a text_unit_ids_set in the code, it is never used:
Line 335 of mixed_context.py

I fixed it by adding:
text_unit_ids_set.add(text_id)

in line 337.

The text was updated successfully, but these errors were encountered:

volksen mentioned this issue

deduplicate sources in local search context #1468

Merged

4 tasks

Contributor Author

volksen commented Dec 4, 2024

tried to create a PR for the issue: #1468
My first PR, please be kind :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment