Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

typescript-vfs still accesses local storage even when storer is provided #2762

Closed
arteme opened this issue Mar 27, 2023 · 2 comments · Fixed by #2796
Closed

typescript-vfs still accesses local storage even when storer is provided #2762

arteme opened this issue Mar 27, 2023 · 2 comments · Fixed by #2796
Labels
Playground Issues that affect the Playground

Comments

@arteme
Copy link

arteme commented Mar 27, 2023

Typescript-vfs module caches data is the local storage or the provided storer. This should -in theory- make typescript-vfs compatible with environments without local storage access, like the web workers. However, even when a storer is provided, the code accesses localStorage instead of storelike here, which is clearly a bug:
920a540#diff-221727bfd6227563593353939e5f0944f6d1465c0f207a55a4a248990e821171L293

@arteme arteme added the Playground Issues that affect the Playground label Mar 27, 2023
@orta
Copy link
Contributor

orta commented Mar 27, 2023

Makes sense to me, you're welcome to send a PR and bump the version number in the package.json 👍🏻

@typescript-bot
Copy link
Collaborator

Hello! As per #2804, we are automatically closing all open issues. Please see #2804 for a description of what issues and PRs can be accepted going forward.

@typescript-bot typescript-bot closed this as not planned Won't fix, can't repro, duplicate, stale Apr 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Playground Issues that affect the Playground
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants