Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Join - warn if predicate doesn't use both LeftRecord and RightRecord #2795

Open
MikeStall opened this issue Dec 29, 2024 · 0 comments
Open
Assignees

Comments

@MikeStall
Copy link
Contributor

Join() should warn if predicate doesn't use both LeftRecord and RightRecord.

This would flag cases like this, which could produce surprising results:
Join(Sequence(3), Sequence(3), LeftRecord.Value in [1,2], JoinType.Left, RightRecord.Value As R2)

Filter() has same issue

We have a basic warning for literals:
Filter([10,20,30], true)

But no warning for:
Filter([10,20,30], true && true)

@anderson-joyle anderson-joyle self-assigned this Dec 30, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants