Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[HLSL] Add RWStructuredBuffer definition to HLSLExternalSemaSource #112775

Closed
Tracked by #88
hekota opened this issue Oct 17, 2024 · 1 comment · Fixed by #113477
Closed
Tracked by #88

[HLSL] Add RWStructuredBuffer definition to HLSLExternalSemaSource #112775

hekota opened this issue Oct 17, 2024 · 1 comment · Fixed by #113477
Assignees
@hekota
Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" HLSL HLSL Language Support

Comments

@hekota
Copy link
Member

hekota commented Oct 17, 2024 •
edited
Loading

Add RWStructuredBuffer definition to HLSLExternalSemaSource.

The RWStructuredBuffer is a read-write buffer of user defined types (UDTs).
https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/sm5-object-rwstructuredbuffer

The resource definition will contain a handle that will be lowered to a dx.RawBuffer target extension type with the UDT as its type argument.

Refer to Proposal for mapping resource attributes for the attribute mapping.

Check that the current implementation of StructuredBuffer matches the latest proposal for the attribute mapping.
@hekota hekota moved this to Planning in HLSL Support Oct 17, 2024
@bogner bogner mentioned this issue Oct 24, 2024
Open
13 tasks
@EugeneZelenko EugeneZelenko added HLSL HLSL Language Support and removed new issue labels Oct 17, 2024
@hekota hekota self-assigned this Oct 19, 2024
@davidcook-msft davidcook-msft moved this from Planning to Active in HLSL Support Oct 22, 2024
@hekota hekota mentioned this issue Oct 22, 2024
Merged
hekota added a commit to hekota/llvm-project that referenced this issue Oct 23, 2024
@hekota
[HLSL] Add RWStructuredBuffer definition to HLSLExternalSemaSource
106ea44 
Add tests for RWStructuredBuffer class definition.
Use shared test files for all structured buffers' constructor and subscript tests.
Keep AST and element-type tests separate for each buffer type because they longer
and failures would be harder to match.

Fixes llvm#112775
@hekota hekota mentioned this issue Oct 23, 2024
Merged
@hekota hekota moved this from Active to Needs Review in HLSL Support Oct 23, 2024
hekota added a commit that referenced this issue Oct 23, 2024
@hekota
[HLSL] Change StructuredBuffer resource class to SRV (#113397)
7a10369 
Change `StructuredBuffer` resource class to SRV (read-only) to match DXC.

Part of #112775
hekota added a commit that referenced this issue Oct 24, 2024
@hekota
[HLSL] Add RWStructuredBuffer definition to HLSLExternalSemaSource (#…
af872d5 
…113477)

Add tests for RWStructuredBuffer class definition. Use shared test files
for all structured buffers' constructor and subscript tests. Keep AST
and element-type tests separate for each buffer type because they longer
and failures would be harder to match.

Fixes #112775
@github-project-automation github-project-automation bot moved this from Needs Review to Closed in HLSL Support Oct 24, 2024
@EugeneZelenko EugeneZelenko added the clang:frontend Language frontend issues, e.g. anything involving "Sema" label Oct 24, 2024
@llvmbot
Copy link
Member

llvmbot commented Oct 24, 2024

@llvm/issue-subscribers-clang-frontend

Author: Helena Kotas (hekota)

Add `RWStructuredBuffer` definition to HLSLExternalSemaSource.

The RWStructuredBuffer is a read-write buffer of user defined types (UDTs).
https://learn.microsoft.com/en-us/windows/win32/direct3dhlsl/sm5-object-rwstructuredbuffer

The resource definition will contain a handle that will be lowered to a dx.RawBuffer target extension type with the UDT as its type argument.

Refer to Proposal for mapping resource attributes for the attribute mapping.

Check that the current implementation of StructuredBuffer matches the latest proposal for the attribute mapping.

NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this issue Nov 4, 2024
@hekota @NoumanAmir657
[HLSL] Change StructuredBuffer resource class to SRV (llvm#113397)
0957a48 
Change `StructuredBuffer` resource class to SRV (read-only) to match DXC.

Part of llvm#112775
NoumanAmir657 pushed a commit to NoumanAmir657/llvm-project that referenced this issue Nov 4, 2024
@hekota @NoumanAmir657
[HLSL] Add RWStructuredBuffer definition to HLSLExternalSemaSource (l…
fbc16f4 
…lvm#113477)

Add tests for RWStructuredBuffer class definition. Use shared test files
for all structured buffers' constructor and subscript tests. Keep AST
and element-type tests separate for each buffer type because they longer
and failures would be harder to match.

Fixes llvm#112775
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@hekota hekota

Labels
clang:frontend Language frontend issues, e.g. anything involving "Sema" HLSL HLSL Language Support
Projects
HLSL Support
Status: Closed
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

[HLSL] Add RWStructuredBuffer definition to HLSLExternalSemaSource hekota/llvm-project
3 participants
@EugeneZelenko @hekota @llvmbot