Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[BUG] Links to existing rom directories are not updated when path changes in the docker compose file #83

Closed
1 task done
EcceGratum opened this issue Jan 4, 2025 · 2 comments

Comments

@EcceGratum
Copy link

EcceGratum commented Jan 4, 2025

Is there an existing issue for this?

  • I have searched the existing issues

Current Behavior

In a docker compose file, when we specify a path to mount existing rom directories like :
-v /path/to/nes/roms:/roms/nes:ro

The link is not updated whenever we make changes to the docker compose and restart the container

Expected Behavior

The links should be updated to reflect the latest path set in the docker compose

Steps To Reproduce

  1. create docker compose with a volume to an existing rom directory :
    -v /path/to/nes/roms/:/roms/nes:ro

  2. create & start the container

  3. stop the container

  4. change the path to the existing rom directory in the the docker compose file :
    -v /path/to/nes/roms:/roms/nes:ro

  5. start the container again

the link in data/nes/roms still point to the old path

Environment

- OS: Kubuntu 24.04
- How docker service was installed: using a docker compose file

CPU architecture

x86-64

Docker creation

services:
  emulatorjs:
    container_name: emulatorjs
    image: lscr.io/linuxserver/emulatorjs:latest
    security_opt:
      - no-new-privileges:true
    restart: unless-stopped
    ports:
      - 3003:3000
      - 82:80
      #- 4001:4001 #optional network
    environment:
      - PUID=$EMULATORJS_PUID
      - PGID=$PGID
      - TZ=$TZ
       #- SUBFOLDER=/ #optional
    volumes:
      - $EMULATORJS_VOLUME/config:/config
      - $EMULATORJS_VOLUME/data:/data
      - $PATH_ROM/Roms/Nintendo - Game Boy/:/roms/gb:ro

Container logs

GID/UID

───────────────────────────────────────

User UID:    975

User GID:    1001

───────────────────────────────────────

[ipfs-upgrade] Checking if fs-repo needs to be upgraded (this may take some time)

ipfs migration: already at version 15

[custom-init] No custom files found, skipping...

Initializing daemon...

Kubo version: 0.24.0

Repo version: 15

System version: amd64/linux

Golang version: go1.21.10

2025/01/04 17:57:08 failed to sufficiently increase receive buffer size (was: 208 kiB, wanted: 2048 kiB, got: 416 kiB). See https://github.com/quic-go/quic-go/wiki/UDP-Buffer-Sizes for details.

Swarm listening on /ip4/127.0.0.1/tcp/4001

Swarm listening on /ip4/127.0.0.1/udp/4001/quic-v1

Swarm listening on /ip4/127.0.0.1/udp/4001/quic-v1/webtransport/certhash/uEiBF4BJxtmAE23f0hjSkOl2dWxxmuueVIh4t8tN0Q0MMBw/certhash/uEiCwKkILx9ZYtof_2IL1VZRA6QSDEPAfYxlOvSX6r797PA

Swarm listening on /ip4/172.18.0.36/tcp/4001

Swarm listening on /ip4/172.18.0.36/udp/4001/quic-v1

Swarm listening on /ip4/172.18.0.36/udp/4001/quic-v1/webtransport/certhash/uEiBF4BJxtmAE23f0hjSkOl2dWxxmuueVIh4t8tN0Q0MMBw/certhash/uEiCwKkILx9ZYtof_2IL1VZRA6QSDEPAfYxlOvSX6r797PA

Swarm listening on /ip6/::1/tcp/4001

Swarm listening on /ip6/::1/udp/4001/quic-v1

Swarm listening on /ip6/::1/udp/4001/quic-v1/webtransport/certhash/uEiBF4BJxtmAE23f0hjSkOl2dWxxmuueVIh4t8tN0Q0MMBw/certhash/uEiCwKkILx9ZYtof_2IL1VZRA6QSDEPAfYxlOvSX6r797PA

Swarm listening on /p2p-circuit

Swarm announcing /ip4/127.0.0.1/tcp/4001

Swarm announcing /ip4/127.0.0.1/udp/4001/quic-v1

Swarm announcing /ip4/127.0.0.1/udp/4001/quic-v1/webtransport/certhash/uEiBF4BJxtmAE23f0hjSkOl2dWxxmuueVIh4t8tN0Q0MMBw/certhash/uEiCwKkILx9ZYtof_2IL1VZRA6QSDEPAfYxlOvSX6r797PA

Swarm announcing /ip4/172.18.0.36/tcp/4001

Swarm announcing /ip4/172.18.0.36/udp/4001/quic-v1

Swarm announcing /ip4/172.18.0.36/udp/4001/quic-v1/webtransport/certhash/uEiBF4BJxtmAE23f0hjSkOl2dWxxmuueVIh4t8tN0Q0MMBw/certhash/uEiCwKkILx9ZYtof_2IL1VZRA6QSDEPAfYxlOvSX6r797PA

Swarm announcing /ip4/173.178.219.117/udp/4001/quic-v1

Swarm announcing /ip4/173.178.219.117/udp/4001/quic-v1/webtransport/certhash/uEiBF4BJxtmAE23f0hjSkOl2dWxxmuueVIh4t8tN0Q0MMBw/certhash/uEiCwKkILx9ZYtof_2IL1VZRA6QSDEPAfYxlOvSX6r797PA

Swarm announcing /ip6/::1/tcp/4001

Swarm announcing /ip6/::1/udp/4001/quic-v1

Swarm announcing /ip6/::1/udp/4001/quic-v1/webtransport/certhash/uEiBF4BJxtmAE23f0hjSkOl2dWxxmuueVIh4t8tN0Q0MMBw/certhash/uEiCwKkILx9ZYtof_2IL1VZRA6QSDEPAfYxlOvSX6r797PA

RPC API server listening on /ip4/127.0.0.1/tcp/5001

WebUI: http://127.0.0.1:5001/webui

Gateway server listening on /ip4/127.0.0.1/tcp/8080

Daemon is ready

Connection to localhost (::1) 3001 port [tcp/*] succeeded!

Connection to localhost (::1) 4001 port [tcp/*] succeeded!

Connection to localhost (127.0.0.1) 80 port [tcp/http] succeeded!

BABEL_TYPES_8_BREAKING is not supported anymore. Use the latest Babel 8.0.0 pre-release instead!

Connection to localhost (::1) 3000 port [tcp/*] succeeded!

[ls.io-init] done.
Copy link

github-actions bot commented Jan 4, 2025

Thanks for opening your first issue here! Be sure to follow the relevant issue templates, or risk having this issue marked as invalid.

@EcceGratum
Copy link
Author

works now, for some reason

@EcceGratum EcceGratum closed this as not planned Won't fix, can't repro, duplicate, stale Jan 5, 2025
@LinuxServer-CI LinuxServer-CI moved this from Issues to Done in Issue & PR Tracker Jan 5, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Development

No branches or pull requests

1 participant