Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Re-examine the SkFontArguments::VariationPosition code regarding life time and zero length input #300

Open
HinTak opened this issue Jan 5, 2025 · 1 comment
Open

Re-examine the SkFontArguments::VariationPosition code regarding life time and zero length input #300

HinTak opened this issue Jan 5, 2025 · 1 comment

Comments

@HinTak
Copy link
Collaborator

HinTak commented Jan 5, 2025

See
#297 (comment)
@HinTak
Copy link
Collaborator Author

HinTak commented Jan 5, 2025

The setvariationpositioncoordinates method needs a zero length check to avoid setting the coords to garbage and potentially segfault there, and it also needs a keep_alive policy when used in the set property usage. And in the constructor too!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@HinTak