Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature: App Launcher - service type detection needed in URL assembly logic #44

Open
chase-weiser88 opened this issue Oct 25, 2024 · 2 comments

Comments

@chase-weiser88
Copy link

chase-weiser88 commented Oct 25, 2024

Current Behavior

When launching an application through the App Launcher with a NodePort service, the extension uses Rancher's proxy URL format:
/k8s/clusters/[cluster-id]/api/v1/namespaces/[namespace]/services/http:[service-name]:80/proxy/

This causes issues with applications that expect to be served from the root path (/).

Desired Behavior

App Launcher should detect the service type (NodePort, LoadBalancer, ClusterIP) and adjust the launch URL accordingly:

  • For NodePort services: Use http://[node-ip]:[nodePort]
  • For proxy URLs: Keep current behavior
  • For Ingress: Keep current behavior

Using the Rancher demo application (monachus/rancher-demo):

  • Direct NodePort access works: http://rancher-demo.cweiser.com:30021
  • Current proxy URL fails: https://rancher.cweiser.com/k8s/clusters/c-m-xds5xzdt/api/v1/namespaces/cweiser/services/http:scale-np-service:80/proxy/
@chase-weiser88 chase-weiser88 changed the title Feature Request: NodePort Service URL Support in App Launcher Feature: NodePort Service URL Support in App Launcher Oct 25, 2024
@chase-weiser88 chase-weiser88 changed the title Feature: NodePort Service URL Support in App Launcher Feature: App Launcher - service type detection needed in URL assembly logic Oct 25, 2024
@krumware
Copy link
Member

@chase-weiser88 @dcharles525 you might be able to collab on this alongside the minor release for the Rancher 2.10 updates

@dcharles525
Copy link
Member

@krumware @chase-weiser88 yeah I can take a look at this for the minor release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

3 participants